Skip to content

Split the tracer parts off from ext directory#3912

Open
bwoebi wants to merge 1 commit into
masterfrom
bob/common-ext
Open

Split the tracer parts off from ext directory#3912
bwoebi wants to merge 1 commit into
masterfrom
bob/common-ext

Conversation

@bwoebi
Copy link
Copy Markdown
Collaborator

@bwoebi bwoebi commented May 23, 2026

Move all the things.
Drop a few obsolete things.
Change nearly no code.

  • git data gets collected in ext/, but git object is collected in tracer/
  • the sidecar is now always spawned, unconditionally

@bwoebi bwoebi requested review from a team as code owners May 23, 2026 00:10
@bwoebi bwoebi requested review from LobeTia and removed request for a team May 23, 2026 00:10
@datadog-prod-us1-5
Copy link
Copy Markdown

datadog-prod-us1-5 Bot commented May 23, 2026

Pipelines  Tests

Fix all issues with BitsAI

⚠️ Warnings

🚦 242 Pipeline jobs failed

DataDog/apm-reliability/dd-trace-php | Extension Tea Tests: [7.0, debug-zts]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error: use of undeclared identifier 'zend_ddtrace_globals' in several files during the build process.

DataDog/apm-reliability/dd-trace-php | Extension Tea Tests: [7.0, debug]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error: undeclared function 'GC_ADDREF' in startup_logging_helpers.h and multiple other errors due to implicit function declarations.

DataDog/apm-reliability/dd-trace-php | Extension Tea Tests: [7.0, nts]   View in Datadog   GitLab

🔧 Fix in code (Fix with Cursor). Compilation error: undeclared functions and identifiers in `ext/startup_logging_helpers.h` and `ext/datadog.c`. Multiple missing definitions lead to build failure.

View all 242 failed jobs.

ℹ️ Info

No other issues found (see more)

🧪 All tests passed
❄️ No new flaky tests detected

Useful? React with 👍 / 👎

This comment will be updated automatically if new data arrives.
🔗 Commit SHA: db7b41e | Docs | Datadog PR Page | Give us feedback!

Copy link
Copy Markdown

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

#include "compatibility.h"

P1 Badge Fix weakrefs include path after move to tracer/

After moving weakrefs.c to tracer/, it still includes "compatibility.h" as if it were in ext/. In this commit config.m4 also drops PHP_ADD_INCLUDE([$ext_srcdir/ext]), so for PHP 8.0/8.1 builds (where weakrefs.c is compiled) the header is no longer resolvable and the build fails. Use #include <ext/compatibility.h> (or restore/include the ext include path) to keep those builds working.

ℹ️ About Codex in GitHub

Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".

Comment thread config.m4 Outdated
@bwoebi bwoebi force-pushed the bob/common-ext branch 6 times, most recently from 1bc2038 to 4a29a16 Compare May 23, 2026 13:28
@pr-commenter
Copy link
Copy Markdown

pr-commenter Bot commented May 23, 2026

Benchmarks [ profiler ]

Benchmark execution time: 2026-05-23 14:25:32

Comparing candidate commit db7b41e in PR branch bob/common-ext with baseline commit 0fb4c56 in branch master.

Found 0 performance improvements and 0 performance regressions! Performance is the same for 30 metrics, 6 unstable metrics.

Signed-off-by: Bob Weinand <bob.weinand@datadoghq.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant