Cache static and per-connection DBM comment fragments#11151
Draft
Cache static and per-connection DBM comment fragments#11151
Conversation
…enter Eliminate repeated URLEncoder.encode() calls and StringBuilder allocation on every query execution when DBM comment injection is enabled. The static config values (service name, env, version) and per-connection values (dbService, hostname, dbName) are now cached and reused across calls. Only truly dynamic values (traceParent, peerService, baseHash) are computed per-call. Config identity is tracked so caches auto-invalidate if Config is rebuilt (e.g. in tests). Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ConcurrentHashMapkeyed by connection tupleMotivation:
SharedDBCommenter.buildComment()calledURLEncoder.encode("UTF-8")for immutable values (service name, env, version) on every single query execution when DBM comment injection is enabled. A newStringBuilderwas allocated per call with repeatedConfig.get()lookups for static configuration.Design
Three-tier caching:
ddps,dddbs,ddh,dddbdde,ddpvddprs,traceparent,ddshTest plan
tag: no release note
tag: ai generated
🤖 Generated with Claude Code