timeseries [2/6] RUM-13949: Implement timeseries pipeline infrastructure#3432
Open
satween wants to merge 2 commits into
Open
timeseries [2/6] RUM-13949: Implement timeseries pipeline infrastructure#3432satween wants to merge 2 commits into
timeseries [2/6] RUM-13949: Implement timeseries pipeline infrastructure#3432satween wants to merge 2 commits into
Conversation
Contributor
Author
This was referenced May 12, 2026
satween
changed the title
timeseries RUM-13949: Implement timeseries pipeline infrastructure
satween
force-pushed
the
tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure
branch
from
cacd357 to
1a6f200
Compare
Codecov Report❌ Patch coverage is Additional details and impacted files@@ Coverage Diff @@
## feature/timeseries #3432 +/- ##
======================================================
+ Coverage 72.08% 72.12% +0.04%
======================================================
Files 961 969 +8
Lines 35399 35515 +116
Branches 5883 5905 +22
======================================================
+ Hits 25515 25613 +98
- Misses 8267 8282 +15
- Partials 1617 1620 +3
🚀 New features to boost your workflow:
|
satween
force-pushed
the
tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure
branch
from
1a6f200 to
7bb00bc
Compare
![chatgpt-codex-connector[bot]](https://avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 7bb00bc938
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
Base automatically changed from
tvaleev/feature/RUM-13949/timeseries-json-schemas-api-surface
to
feature/timeseries
May 14, 2026 11:02
Introduces the core primitives for the timeseries data pipeline: `Timeseries` interface (with `@NoOpImplementation`), `DataPoint`, `Buffer`, `DeltaCompression`, `Pipeline`, `EventWriter`, `JsonSerializer` interface, `DataPointsReader` interface, `VitalReaderWrapper`, and the generic `RumSessionScopeTimeseries` per-session collector. Also adds detekt safe-call allowlist entries for the new APIs. ### What does this PR do? Adds the foundational building blocks shared by all timeseries metric types: the `Timeseries` lifecycle interface, immutable `DataPoint`, the `Buffer`/`DeltaCompression`/`Pipeline` data-processing chain, the `EventWriter` flush boundary, `JsonSerializer` interface, `DataPointsReader`/`VitalReaderWrapper` for OS-metric abstraction, and `RumSessionScopeTimeseries` — the generic per-session scheduler that drives sampling, batching, and writing for any metric type. ### Motivation Establishes the shared infrastructure that CPU and memory collectors will extend, keeping primitive types and pipeline logic isolated so they can be reviewed without metric-specific details. ### Additional Notes Unit tests cover all primitives. `DataPointForgeryFactory` and the `Configurator` registration are included so subsequent commits can write tests against generated `DataPoint` values. `RumSessionTypeExt` session-type mappings are added here (used by both CPU and memory serializers in later commits).
satween
force-pushed
the
tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure
branch
from
7bb00bc to
f1063fa
Compare
kikoveiga
reviewed
May 15, 2026
Contributor
kikoveiga
left a comment
kikoveiga
left a comment
There was a problem hiding this comment.
Nice! Just left some small comments, worth to check what Codex said about some concurrency issues.
0xnm
reviewed
May 18, 2026
This comment has been minimized.
This comment has been minimized.
0xnm
reviewed
May 21, 2026
- Switch `RumSessionScopeTimeseries` from owning a per-session executor to accepting a shared `ScheduledExecutorService` (no creation, no shutdown). - Add `RumSessionScopeTimeseriesFactory` so reviewers can see how `RumSessionScopeTimeseries` is instantiated. - Wire timeseries `start`/`stop` lifecycle into `RumSessionScope` (`startTimeseries`/`stopTimeseries` called from `renewSession`/`stopSession`). - Remove 3 unused entries added to `detekt_custom_safe_calls.yml` in this branch.
satween
force-pushed
the
tvaleev/feature/RUM-13949/timeseries-pipeline-infrastructure
branch
from
fa10624 to
5968d81
Compare
Contributor
Author
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 5968d81b3b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| ) { | ||
| if (!isActive(generation)) return@scheduleSafe | ||
| try { | ||
| synchronized(pipeline, pipeline::execute) |
There was a problem hiding this comment.
If a scheduled tick passes the isActive(generation) check and then onSessionStop() runs before this lock is acquired, the stop path sets the state to STOPPED and flushes the same pipeline first; after that, this tick still executes pipeline.execute(), can append a new sample, and will not reschedule or flush it because the final isActive check is false. In that stop/race window the last sample is silently left in the buffer, so the runnable should re-check activity after acquiring the lock or the stop path should otherwise prevent post-flush execution.
Useful? React with 👍 / 👎.
satween
changed the title
timeseries RUM-13949: Implement timeseries pipeline infrastructuretimeseries [2/5] RUM-13949: Implement timeseries pipeline infrastructure
satween
changed the title
timeseries [2/5] RUM-13949: Implement timeseries pipeline infrastructuretimeseries [2/6] RUM-13949: Implement timeseries pipeline infrastructure
ambushwork
approved these changes
May 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
What does this PR do?
Adds the foundational building blocks shared by all timeseries metric types: the
Timeserieslifecycle interface, immutableDataPoint, theBuffer/DeltaCompression/Pipelinedata-processing chain, theEventWriterflush boundary,JsonSerializerinterface,DataPointsReader/VitalReaderWrapperfor OS-metric abstraction, andRumSessionScopeTimeseries— the generic per-session scheduler that drives sampling, batching, and writing for any metric type.Motivation
Establishes the shared infrastructure that CPU and memory collectors will extend, keeping primitive types and pipeline logic isolated so they can be reviewed without metric-specific details.
Review checklist (to be filled by reviewers)