Entity cache-related cleanup#1962
Merged
slipher merged 4 commits intoDaemonEngine:masterfrom May 1, 2026
Merged
Conversation
It should return a response with the expected number of items.
It could be annoying when following the call hierarchy across the function pointers, if the functions have different name than the function pointers.
DolceTriade
reviewed
Apr 30, 2026
| void trap_R_DrawStretchPic( float x, float y, float w, float h, float s1, float t1, float s2, float t2, qhandle_t hShader ); | ||
| void trap_R_DrawRotatedPic( float x, float y, float w, float h, float s1, float t1, float s2, float t2, qhandle_t hShader, float angle ); | ||
| void trap_R_ModelBounds( clipHandle_t model, vec3_t mins, vec3_t maxs ); | ||
| int trap_R_LerpTag( orientation_t *tag, const refEntity_t* refent, const char *tagName, int startIndex ); |
Contributor
There was a problem hiding this comment.
do we care about compat with other games? this is a regular q3 trap call right?
Member
Author
There was a problem hiding this comment.
It would be nice to provide an API matching the ioq3 one. But this function (recently deleted) does not have the same signature as the original anyway. See #1964
DolceTriade
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The most important thing there is
Fix null renderer SyncLerpTags: this ensures the tty client's IPC response has the expected number of requested items. The current behavior of returning and empty vector is prone to cause crashes if the cgame assumes the vector has the right length.Rest of the commits are just cosmetic.