Remove useless trap_R_AddRefEntityToScene return value#1959
Merged
slipher merged 1 commit intoDaemonEngine:masterfrom Apr 30, 2026
Merged
Remove useless trap_R_AddRefEntityToScene return value#1959slipher merged 1 commit intoDaemonEngine:masterfrom
slipher merged 1 commit intoDaemonEngine:masterfrom
Conversation
It returns how many entities have been added to the current scene, but there is nothing useful the cgame can do with this number. All the APIs with entity id require adding the entity to the cache to get an id, not to the scene.
DolceTriade
approved these changes
Apr 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
It returns how many entities have been added to the current scene, but there is nothing useful the cgame can do with this number. All the APIs with entity id require adding the entity to the cache to get an id, not to the scene.
Companion: Unvanquished/Unvanquished#3528