Skip to content

Implement CMAC#377

Open
a-dma wants to merge 1 commit into
DaGenix:masterfrom
a-dma:master
Open

Implement CMAC#377
a-dma wants to merge 1 commit into
DaGenix:masterfrom
a-dma:master

Conversation

@a-dma

@a-dma a-dma commented Jul 6, 2016

Copy link
Copy Markdown

I was playing around with CMAC and I thought I'd contribute back what code I have.

I'm still learning rust, so the code is by no means perfect. Also, given the lack of documentation there was a bit of guesswork to find things that were already implemented.

A couple of possible (but for me tricky) improvements are:

  • Use a FixedBuffer for storing the MAC result and take advantage of StandardPadding;
  • Try to shoehorn in a CbcEncryptor with an empty IV rather than doing the XOR'ing manually.

Add a generic implementation of CMAC using a BlockEncryptor.
Tested only against AES128, AES192 and AES256.
@flybayer

Copy link
Copy Markdown

Any chance this will be merged to master soon?

@flybayer

Copy link
Copy Markdown

@DaGenix is anything besides the failing build preventing this from being merged?

@tvladyslav

Copy link
Copy Markdown

@flybayer last commit was merged 7 month ago. It smells like a dead repo. I thought about making one small PR, but now I have doubts...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants