Skip to content

Ingress migration#202

Merged
Edu-GG merged 19 commits into
mainfrom
GG/IngressValidation
Jul 17, 2026
Merged

Ingress migration#202
Edu-GG merged 19 commits into
mainfrom
GG/IngressValidation

Conversation

@Edu-GG

@Edu-GG Edu-GG commented Jul 15, 2026

Copy link
Copy Markdown
Contributor

Migrated the Ingress POC into main app to allow data to populate.
CsvSchemaFileProcessor

  • Checksum validation (SHA-256)
  • Record counting
  • Per-school group validation with comprehensive error collection
  • JSON transformation and type conversion
  • Per-school JSON file writing
  • Summary CSV generation
  • No file write on validation fails

Visual feedback during processing

Updated memory allowance on Terraform due to high memory usage as processing held in memory to save storage writes.

License added for newtonsoft to allow schema validations on over 1000 records.

ToDo: Manage memory better so we can reduce required RAM

@github-actions

github-actions Bot commented Jul 15, 2026

Copy link
Copy Markdown

Review app for PR 202 was deleted

@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from 8c1351a to 243ed48 Compare July 16, 2026 10:56
@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from f5576d3 to a8e6f2a Compare July 16, 2026 11:19
@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from bfc084c to d26016c Compare July 16, 2026 14:11
@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from 2d7bd31 to a69acd1 Compare July 16, 2026 18:14
@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from a69acd1 to 5e370c0 Compare July 16, 2026 18:29
@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from 72a6b58 to 2550f69 Compare July 17, 2026 09:24
Edu-GG and others added 16 commits July 17, 2026 10:28
- Removed hardcoded license string (lines 275-276)
- Keep configuration-driven license registration (lines 110-117) which is the proper approach
- License key should be provided via configuration (appsettings.json or environment variables) in deployed environments
- This prevents sensitive credentials from being committed to source code
- Updated comment to clarify controller-level request size limit intent
@Edu-GG
Edu-GG force-pushed the GG/IngressValidation branch from 2550f69 to 678e031 Compare July 17, 2026 10:01
@Edu-GG
Edu-GG marked this pull request as ready for review July 17, 2026 10:13
@Edu-GG Edu-GG changed the title WIP - Review App Checks Ingress migration Jul 17, 2026
@Edu-GG
Edu-GG requested a review from davidgouge July 17, 2026 10:13
@Edu-GG
Edu-GG merged commit becb42f into main Jul 17, 2026
8 checks passed
@Edu-GG
Edu-GG deleted the GG/IngressValidation branch July 17, 2026 11:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants