Skip to content

Add saved query management functions.#191

Open
sfc-gh-jsoyland wants to merge 2 commits intomainfrom
jsoyland/manage_saved_queries
Open

Add saved query management functions.#191
sfc-gh-jsoyland wants to merge 2 commits intomainfrom
jsoyland/manage_saved_queries

Conversation

@sfc-gh-jsoyland
Copy link
Copy Markdown
Collaborator

@sfc-gh-jsoyland sfc-gh-jsoyland commented May 4, 2026

No description provided.

@sfc-gh-jsoyland sfc-gh-jsoyland requested a review from a team as a code owner May 4, 2026 16:06
@sfc-gh-jsoyland
Fix linter errors
0c9675a 
Linter didn't like:
```
       > src/cb/saved_query.cr:95:29
       > [W] Lint/NotNil: Avoid using `not_nil!`
       > > name:         @name.not_nil!,
```

So removed the `not_nil!`.  It is now consistent with other
functions in the existing code base by not type-annotating
client method parameters
@sfc-gh-jsoyland
Copy link
Copy Markdown
Collaborator Author

sfc-gh-jsoyland commented May 4, 2026

Tried a 3-phased approach to this PR with checkpoints that I could review. I also found that it made the process repeatable on a fresh branch.

  1. First asked Claude to research how to best apply a new function by reviewing existing code and API documentation. Then to persist findings to 01-research.md for review.

  2. Asked Claude to plan what changes would be needed based on findings from the research document: 02-planning.md

  3. Asked Claude to produce a testing plan for review post-implementation. That way I could review the doc and make sure that it wasn't trying to cheat in it's success criteria: 03-testing.md

Once artifacts were generated, started a new session and asked Claude to implement changes. Everything generated/passed on the first pass, save for the linter error.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

1 participant

@sfc-gh-jsoyland