fix(dcent): use official D'CENT symbol asset for productIcon#101
Open
SeungjunWe wants to merge 1 commit into
Open
fix(dcent): use official D'CENT symbol asset for productIcon#101SeungjunWe wants to merge 1 commit into
SeungjunWe wants to merge 1 commit into
Conversation
Replace the hand-crafted, inlined base64 SVG reproduction of the D'CENT logo with the wallet's official hosted icon asset, matching the convention every other module uses (a hosted icon URL rather than an inlined data URI).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
DcentModule.productIconpreviously inlined a hand-crafted base64-encoded SVG reproduction of the D'CENT logo, unlike every other module in the kit, which pointsproductIconat a hosted icon URL (e.g.https://stellar.creit.tech/wallet-icons/*.png).https://assets.dcentwallet.com/images/dcent-symbol.svg), so the icon stays in sync with D'CENT's official branding and the module follows the same convention as the rest of the kit.Test plan
productIconrenders correctly in the wallet selection UI (Avatar component) using the new URL