check_drivesize: accept drive argument if drive+seperator string equals the argument#384
Merged
Merged
Conversation
added 2 commits
May 28, 2026 18:08
…ls the argument example drive=/boot and drive=/boot/ to arguments both work now, previously it was only /boot
…the log message about seperator check_drivesize drive='/<drive>/' used to print perfdata labels using the '/drive/' unlike drive='/[drive]' trim that seperator if there is a match with the drive including the seperator at the end. now both drive='/[drive]' and drive='/[drive]/' forms use '/[drive]' in perfdata labels check_drivesize drive='/tmp/' OK - All 1 drive(s) are ok |'/tmp used'=464523264B;26737934336;30080176128;0;33422417920 '/tmp used %'=1.4%;80;90;0;100 additionally, improve the confusing log message. now is more verbose about what it does: [check_drivesize_other:125] For search path: '/tmp/', taking drive: '/tmp' since adding a seperator: '/' matches the search path: '/tmp/'
5869e1b to
edf836b
Compare
Contributor
Author
|
Example: Direct match with the drive, without separator Not a direct match, has an extra separator at the end |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
example drive=/boot and drive=/boot/ to arguments both work now, previously it was only /boot
checked windows as it has its own setCustomPath function. It is already accepting all forms of the drive argument, no need to make changes