check files: skip files with whitespace names#383
Open
inqrphl wants to merge 1 commit into
Open
Conversation
linux allows files that have whitespaces in them. this can cause problems when the "<filename> size" perfdata is added, which may be displayed as "size" on Thruk. detect these files and skip them append total_size metric always, without needing to have it inside a condition. add some comments
Contributor
|
i am unsure, wouldn't it be better to use quotes in the perfdata output instead? Of course this is a probably rare corner case, but ' ' is a totally valid linux file name. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
linux allows files that have whitespaces in them. this can cause problems when the " size" perfdata is added, which could be displayed as "size" somwhere that trims the string.
detect these files and skip them
append total_size metric always, without needing to have it inside a condition.
add small comments to the code