Skip to content

London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code#1060

Closed
Ebrahim-Moqbel wants to merge 23 commits intoCodeYourFuture:mainfrom
Ebrahim-Moqbel:feature/wireframe
Closed

London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code#1060
Ebrahim-Moqbel wants to merge 23 commits intoCodeYourFuture:mainfrom
Ebrahim-Moqbel:feature/wireframe

Conversation

@Ebrahim-Moqbel
Copy link
Copy Markdown

@Ebrahim-Moqbel Ebrahim-Moqbel commented Jan 25, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

I have made the changes and updated the contents and by PR this commits

Questions

@netlify
Copy link
Copy Markdown

netlify Bot commented Jan 25, 2026

Deploy Preview for cyf-onboarding-module ready!

Name Link
🔨 Latest commit 48b9f84
🔍 Latest deploy log https://app.netlify.com/projects/cyf-onboarding-module/deploys/698766ee5cef9e0008fec2ee
😎 Deploy Preview https://deploy-preview-1060--cyf-onboarding-module.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
Lighthouse
Lighthouse
2 paths audited
Performance: 91 (🔴 down 9 from production)
Accessibility: 100 (no change from production)
Best Practices: 100 (no change from production)
SEO: 86 (no change from production)
PWA: -
View the detailed breakdown and full score reports

To edit notification comments on pull requests, go to your Netlify project configuration.

@github-actions

This comment has been minimized.

@Ebrahim-Moqbel Ebrahim-Moqbel marked this pull request as ready for review January 25, 2026 16:28
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 25, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 25, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 25, 2026
@github-actions

This comment has been minimized.

@github-actions github-actions Bot removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026
@github-actions

This comment has been minimized.

@Ebrahim-Moqbel Ebrahim-Moqbel changed the title London | JAN-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code London | ITP-JAN-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code Jan 26, 2026
@github-actions

This comment has been minimized.

@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Jan 26, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Module-Onboarding The name of the module. label Feb 2, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A well-prepared PR makes it easier for reviewers to approve it with minimal back-and-forth.
Can you take a look at this PR Guide and General Feedback to see if there
is anything you can do to make your PR more robust and ready?
Doing so can help speed up the review process.

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels Feb 3, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 7, 2026

There isn't any new commits on this PR branch since I left a comment 4 days ago. Did you forget to push your changes to GitHub? The commit you made to the cloned repo on your computer are not sync to GitHub automatically, you will need to manually sync/push the changes to GitHub.

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@Ebrahim-Moqbel
Copy link
Copy Markdown
Author

There isn't any new commits on this PR branch since I left a comment 4 days ago. Did you forget to push your changes to GitHub? The commit you made to the cloned repo on your computer are not sync to GitHub automatically, you will need to manually sync/push the changes to GitHub.

Thank you for your comment I believe I have done all the tasks can you spot me what I need to do. Thank you

@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 7, 2026

According to https://validator.w3.org/, there are errors in your code. Can you fix them?

@cjyuan cjyuan removed the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@Ebrahim-Moqbel Ebrahim-Moqbel added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label Feb 7, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented Feb 7, 2026

Changes look good.

Please note that in CYF courses, the recommended way to inform the reviewer of your changes is to do both of the following:

  • Reply to their feedback.
    • In the responses, clarify how each piece of feedback was addressed to demonstrate that you've carefully reviewed the suggestions.
      • You may find the suggestions in this PR Guide useful.
    • Your response may trigger a notification (depending on the reviewer's settings), helping ensure they’re aware of the updates you’ve made.
  • Replace the "Reviewed" label by a "Needs review" label (which you have done -- great!)
    • Without this label, the reviewer would not know if your changes is ready to be reviewed.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels Feb 7, 2026
@illicitonion
Copy link
Copy Markdown
Member

Closing PR because the January ITP run has finished. Feel free to re-open if you're still working on it.

@Ebrahim-Moqbel Ebrahim-Moqbel changed the title London | ITP-JAN-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code London | ITP-MAY-2026 | Ebrahim Moqbel | sprint 1 | Wireframe to Web code May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Module-Onboarding The name of the module. 📅 Sprint 1 Assigned during Sprint 1 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants