Skip to content

Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 2 | Objects#1216

Open
Jacknguyen4438 wants to merge 12 commits intoCodeYourFuture:mainfrom
Jacknguyen4438:Sprint-2-Objects
Open

Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 2 | Objects#1216
Jacknguyen4438 wants to merge 12 commits intoCodeYourFuture:mainfrom
Jacknguyen4438:Sprint-2-Objects

Conversation

@Jacknguyen4438
Copy link
Copy Markdown

@Jacknguyen4438 Jacknguyen4438 commented May 7, 2026

Learners, PR Template

Self checklist

  • I have titled my PR with Region | Cohort | FirstName LastName | Sprint | Assignment Title
  • My changes meet the requirements of the task
  • I have tested my changes
  • My changes follow the style guide

Changelist

Hello and thank you for checking this PR. I have completed this courses work during JAN-ITP, here is the link of the old PR for this course work #1204 . I have done a completed check both new and old required task need to be done so that I can resubmission for a review.

Questions

No Question.

@github-actions

This comment has been minimized.

@Jacknguyen4438 Jacknguyen4438 changed the title Glasgow| 2026-ITP-Jan | Tuan Nguyen| Sprint 2 | Objects Glasgow| 2026-ITP-May | Tuan Nguyen| Sprint 2 | Objects May 7, 2026
@github-actions

This comment has been minimized.

@Jacknguyen4438 Jacknguyen4438 added 📅 Sprint 2 Assigned during Sprint 2 of this module Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Module-Data-Groups The name of the module. Core This is a core task and should be completed by all trainees labels May 7, 2026
Copy link
Copy Markdown
Contributor

@cjyuan cjyuan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To provide fuller context for this code review, can you include the link to your previous reviewed PR in the PR description?

@cjyuan cjyuan added Reviewed Volunteer to add when completing a review with trainee action still to take. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. labels May 10, 2026
@Jacknguyen4438 Jacknguyen4438 added the Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. label May 10, 2026
@Jacknguyen4438
Copy link
Copy Markdown
Author

Hello @cjyuan Thank you for your feedback on my PR description. I have change the description so that it can explain better on what this PR for.

@cjyuan cjyuan added Complete Volunteer to add when work is complete and all review comments have been addressed. and removed Needs Review Trainee to add when requesting review. PRs without this label will not be reviewed. Reviewed Volunteer to add when completing a review with trainee action still to take. labels May 10, 2026
@cjyuan
Copy link
Copy Markdown
Contributor

cjyuan commented May 10, 2026

All good.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Complete Volunteer to add when work is complete and all review comments have been addressed. Core This is a core task and should be completed by all trainees Module-Data-Groups The name of the module. 📅 Sprint 2 Assigned during Sprint 2 of this module

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants