Make TCR diagnostic compatible with CMIP7 data#686
Open
schlunma wants to merge 6 commits into
Open
Conversation
schlunma
commented
May 22, 2026
This was referenced May 22, 2026
Contributor
Author
|
Will mark this as "ready for review" once corresponding ESMValTool PR has been merged. |
Codecov Report✅ All modified and coverable lines are covered by tests.
Flags with carried forward coverage won't be shown. Click here to find out more.
🚀 New features to boost your workflow:
|
schlunma
commented
May 29, 2026
| - CMIP7.CMIP.MRI.MRI-ESM2-0.piControl.r1i2p1f1.glb.mon.tas.tavg-h2m-hxy-u.gn.v20191205 | ||
| cmip7_gn_NESM3_r1i1p1f1: | ||
| cmip7: | ||
| - CMIP7.CMIP.NUIST.NESM3.1pctCO2.r1i1p1f1.glb.mon.tas.tavg-h2m-hxy-u.gn.v20190707 |
Contributor
Author
There was a problem hiding this comment.
This looks wrong, there's no parent experiment.
Contributor
Author
|
I copied the obtained file from the failing regression test to make it pass here. However, I think there are some problems with this (see my comments). Otherwise this is ready for review now. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Addresses #647.
Checklist
Please confirm that this pull request has done the following:
changelog/