Code. Add get params to bot detector wrapper#50
Open
alexander-b-clean wants to merge 2 commits into
Open
Conversation
alexandergull
requested changes
May 19, 2026
| public static function getFrontendHTMLCode($warn_if_js_disabled = false) | ||
| { | ||
| $warn = $warn_if_js_disabled ? '<noscript><div>Please, enable JavaScript in the browser to process the form</div></noscript>' : ''; | ||
| $url = static::BOT_DETECTOR_LIBRARY_URL . '?ver=' . gmdate('Ymd'); |
Member
There was a problem hiding this comment.
gmdate('Ymd');
This will drop the browser cache, you can use constant APBCT_VERSION instead.
Glomberg
requested changes
May 21, 2026
Member
Glomberg
left a comment
Glomberg
left a comment
There was a problem hiding this comment.
My questions are here https://app.doboard.com/1/task/34668#comment_314961
AntonV1211
requested changes
May 21, 2026
| public static function getFrontendHTMLCode($warn_if_js_disabled = false) | ||
| { | ||
| $warn = $warn_if_js_disabled ? '<noscript><div>Please, enable JavaScript in the browser to process the form</div></noscript>' : ''; | ||
| $url = static::BOT_DETECTOR_LIBRARY_URL . '?ver=' . gmdate('Ymd'); |
Contributor
There was a problem hiding this comment.
I agree with the remark
There was a problem hiding this comment.
Pull request overview
Adds a manually maintained library version and appends it as a query parameter to the bot detector wrapper URL for frontend cache/version tracking.
Changes:
- Introduces
APBCT_VERSIONin the package entrypoint. - Uses that version in
getFrontendHTMLCode()when building the bot detector script URL. - Documents the manual version bump process in the README.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
README.md |
Documents where the library version is defined and how it is updated. |
cleantalk-antispam.php |
Adds the APBCT_VERSION constant. |
lib/CleantalkAntispam.php |
Appends the version query parameter to the bot detector script URL. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| public static function getFrontendHTMLCode($warn_if_js_disabled = false) | ||
| { | ||
| $warn = $warn_if_js_disabled ? '<noscript><div>Please, enable JavaScript in the browser to process the form</div></noscript>' : ''; | ||
| $version = defined('APBCT_VERSION') ? \APBCT_VERSION : '1.0'; |
| @@ -1,5 +1,7 @@ | |||
| <?php | |||
|
|
|||
| const APBCT_VERSION = '4.4'; | |||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/34668