Fix. Code. Checking server settings#2
Merged
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates RemoteCalls::getSiteUrl() to sanitize the scheme/host/path derived from $_SERVER (including a fallback from SCRIPT_URL to REQUEST_URI) and adds PHPUnit coverage to validate sanitization behavior and the fallback logic.
Changes:
- Harden
RemoteCalls::getSiteUrl()by sanitizingHTTP_HOSTand stripping unsafe characters from the URL path, with a fallback toREQUEST_URIwhenSCRIPT_URLis missing. - Add PHPUnit tests to verify sanitization of
SCRIPT_URLand fallback parsing ofREQUEST_URI. - Remove an incorrect
@param $hostfrom theperform()docblock.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 3 comments.
| File | Description |
|---|---|
| RemoteCalls.php | Sanitizes scheme/host/path when building the site URL and corrects the perform() docblock. |
| tests/RemoteCalls/RemoteCallsGetSiteUrlTest.php | Adds unit tests for getSiteUrl() sanitization and fallback behavior. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Glomberg
approved these changes
May 27, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://app.doboard.com/1/task/49374