Fetch UnsatCoreTAC files via unsat_core_map.json instead of the whole archive#2
Merged
Conversation
shellygr
reviewed
Jul 16, 2026
shellygr
reviewed
Jul 16, 2026
shellygr
previously approved these changes
Jul 16, 2026
shellygr
left a comment
Contributor
There was a problem hiding this comment.
lgtm, two memory related nits
Contributor
|
also - what is the rule_id? |
Contributor
Author
It's a unique rule identifier. We added it to the prover already some time ago, but it was not exported. There is a prover PR that exports it to treeView (which allows us to match treeView items (rule&method results) to corresponding unsat core files). |
shellygr
approved these changes
Jul 17, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the job's
unsat_core_map.json({ ruleId -> [UnsatCoreTAC .txt] }) to fetch onlythe referenced files via the per-file endpoint, instead of pulling the full output tar.
fetch_output_file(job, rel_path)— fetch oneReports/-relative file via the/f/<name>endpoint (added to all fetchers).
fetch_statsdatanow delegates to it.unsat_core_map/unsat_core_filenames/read_unsat_cores— look up a rule's unsat-core.txtfiles (and their contents) by its treeViewruleId.extract_unsat_core_files— fetches only the mapped files; falls back to the output tar whenthe map is absent.
CheckResult.rule_id(parsed from the treeView node) andNodeStatus.SANITY_FAILED.Consumer flow: parse the treeView, select rules by status, then fetch their
.txtbyrule_id.Works for any rule with unsat cores (verified, failed
satisfy, or vacuous), not just sanity.