PutCounterAll: update cards with ValidCardsDesc

[Hanmac]

This adds ValidCardsDesc to PutCounterAll to make better StackDescription
(Spell and Activated Abilities)

[tool4ever]

a) I still think it's pointless teaching scripters to use something like ValidCardsDesc$ creature you control | ValidCardsDesc2$ other planeswalker you control instead of StackDescription$ SpellDescription for everything 👎

b) how many of these cards are actually dynamic?
the very few could also just use StackDescription$ REP X counters_{n:X}...

[Hanmac]

a) I still think it's pointless teaching scripters to use something like ValidCardsDesc$ creature you control | ValidCardsDesc2$ other planeswalker you control instead of StackDescription$ SpellDescription for everything 👎

It's the same as using ValidTgtsDesc for the TargetDescription #8806

b) how many of these cards are actually dynamic?

You mean from the Valid Desc or from the Amount? For Amount, there are these examples:

• Wild Onslaught for example does 1 or 2 counters
• Vraska, Regal Gorgon does For each creature card in your graveyard

[tool4ever]

It's the same as using ValidTgtsDesc for the TargetDescription #8806

But for target prompt we don't really have another script param we can just reuse...

You mean from the Valid Desc or from the Amount?

doesn't really matter, SpellAbilityEffect#tokenizeString can handle both

[Hanmac]

But this is more ugly

StackDescription$ REP X counters_{n:X}

[tool4ever]

well ok, then just use the special params for these cases?

[Hanmac]

well ok, then just use the special params for these cases?

it is already used for this:

forge/forge-game/src/main/java/forge/game/ability/effects/CountersPutAllEffect.java

Lines 20 to 28 in f996041

	final StringBuilder sb = new StringBuilder();
	final CounterType cType = CounterType.getType(sa.getParam("CounterType"));
	final int amount = AbilityUtils.calculateAmount(sa.getHostCard(), sa.getParamOrDefault("CounterNum", "1"), sa);
	final String zone = sa.getParamOrDefault("ValidZone", "Battlefield");
	sb.append("Put ");
	sb.append(Lang.nounWithNumeralExceptOne(amount, cType.getName().toLowerCase() + " counter"));
	sb.append(" on each ");

[tehdiplomat]

Yea i think I agree with the statement that this Desc field is kinda useless when StackDescription$ SpellDescription is cleaner. i.e. in cases where there's no variability. But i dont necessarily mind having the buildable description for those cases.