Replace Scryfall's API with custom API using Scryfall data#11093
Open
Eradev wants to merge 1 commit into
Open
Conversation
tehdiplomat
reviewed
Jul 15, 2026
| } | ||
|
|
||
| return String.format("%s/%s/%s?format=image&version=%s%s", editionCode, encodeUtf8(cardCollectorNumber), | ||
| return String.format("%s/%s/%s?version=%s%s", editionCode, encodeUtf8(cardCollectorNumber), |
Contributor
There was a problem hiding this comment.
Since you are accepting get params, does format=image not just get ignored by your webserver?
Contributor
Author
There was a problem hiding this comment.
Yes it is ignored.
Contributor
There was a problem hiding this comment.
So I feel like we shouldn't be making these line changes. Maybe just have a UI element called "Use Scryfall Mirror" that passes in the new URL instead of scryfalls?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We've seen increased reports of throttling by Scryfall recently.
This replaces Scryfall's API with my own which uses Scryfall's bulk data to generate a lookup table to their CDN.
I can give access to the repo if maintainers want access.