Improve the README.md#260
Merged
Merged
Conversation
Coverage Report
|
|||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||||
kbabioch
reviewed
Mar 12, 2026
kbabioch
reviewed
Mar 12, 2026
Comment on lines
+74
to
+87
| ```txt | ||
| field ←-owns 0..n-- data_vector | ||
| ↑ | ||
| is | ||
| +----------------+-----+-------+-------------+----------+ | ||
| | | | | | | ||
| Parameters Calculations Visiblities Holdings Inputs | ||
| ↑ ↑ ↑ ↑ ↑ | ||
| uses uses uses uses uses | ||
| | | | | | | ||
| +---------- LuxtronikData ----+ LuxtronikSmartHomeData | ||
| ↑ ↑ | ||
| +--is----LuxtronikAllData----is--+ | ||
| ``` |
Collaborator
There was a problem hiding this comment.
Also a good candidate for mermaid?
kbabioch
approved these changes
Mar 12, 2026
Collaborator
kbabioch
left a comment
There was a problem hiding this comment.
Another good improvement. As annotated, maybe mermaid could be used. In case you don't want to, let me know, then I'll proceed.
Collaborator
|
Looks good to me, should I merge this? |
Contributor
Author
|
Yes, you’re welcome to do that. I don’t have any further changes planned at the moment. |
Contributor
Author
|
Oops. I clicked the wrong button. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add further information about the module structure and the use of the Luxtronik interface.