Control the font used for book buttons in RAB books (BL-16351)#7977
Open
StephenMcConnel wants to merge 1 commit into
Open
Control the font used for book buttons in RAB books (BL-16351)#7977StephenMcConnel wants to merge 1 commit into
StephenMcConnel wants to merge 1 commit into
Conversation
Contributor
|
| Filename | Overview |
|---|---|
| src/content/bookLayout/basePage-sharedRules.less | Adds a CSS rule controlling font-size (via CSS variable with 10pt fallback) and font-family for .bloom-bookButton p elements nested inside canvas elements; font name NotoSans is intentional and consistent with @font-face declarations elsewhere in the codebase |
Reviews (1): Last reviewed commit: "Control the font used for book buttons i..." | Re-trigger Greptile
hatton
requested changes
Jun 17, 2026
hatton
left a comment
Member
There was a problem hiding this comment.
@hatton made 1 comment.
Reviewable status: 0 of 1 files reviewed, 1 unresolved discussion (waiting on StephenMcConnel).
src/content/bookLayout/basePage-sharedRules.less line 293 at r1 (raw file):
.bloom-canvas .bloom-canvas-element .bloom-link-grid .bloom-bookButton p { font-size: var(--DefaultBookButtonFontSize, 10pt); font-family: Andika, NotoSans, sans-serif;
What if their language needs a different font? It doesn't seem like any fixed list will do here.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Devin review
This change is