feat(sdk-core): add signRecoveryMpcV2 for EdDSA MPCv2 offline signing#9025
Closed
vibhavgo wants to merge 2 commits into
Closed
feat(sdk-core): add signRecoveryMpcV2 for EdDSA MPCv2 offline signing#9025vibhavgo wants to merge 2 commits into
vibhavgo wants to merge 2 commits into
Conversation
Adds a standalone helper to decrypt and validate both EdDSA MPCv2 reduced keycards, returning typed Buffer key shares and the derived commonKeyChain. Mirrors the ECDSA getMpcV2RecoveryKeyShares pattern as part of the SJCL-to-Argon2 migration. - Decrypt both keycards in parallel via Promise.all - Use bitgo.decryptAsync (v1 + v2) when a BitGoBase instance is provided; fall back to sjcl.decrypt (v1 only) otherwise - Validate pub and rootChainCode separately with distinct error messages - Wrap getDecodedReducedKeyShare in try-catch to surface a descriptive error for malformed or public-only keycards - Add 3 unit tests: v1 happy path, malformed keycard, mismatched keys Ticket: WCI-396
Ticket: WCI-397 Implements local 2-party MPS signing for EdDSA MPCv2 recovery flows, mirroring the existing ECDSA signRecoveryMpcV2 pattern. The function runs the MPS DSG protocol to round 3 using user and backup key shares, then verifies the resulting 64-byte Ed25519 signature against the child public key derived via deriveUnhardenedMps. - export `signRecoveryMpcV2` from eddsaMPCv2.ts - drives `MPSUtil.executeTillRound(3, ...)` locally with user + backup DSG instances - derives the child public key via `deriveUnhardenedMps(commonKeyChain, derivationPath)` - verifies the signature with `nacl.sign.detached.verify`; throws on mismatch - add unit tests for `signRecoveryMpcV2` - valid path: 64-byte signature verifies against derived public key - tampered message: signature does not verify against a different message - wrong commonKeyChain: throws "EdDSA MPCv2 recovery signature verification failed" Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds
signRecoveryMpcV2tomodules/sdk-core/src/bitgo/utils/tss/eddsa/eddsaMPCv2.tsas a standalone export for EdDSA MPCv2 recovery signing flows. The function drives the MPS DSG protocol locally to completion using user and backup key shares (obtained fromgetEddsaMPCv2RecoveryKeyShares), then verifies the resulting 64-byte Ed25519 signature against the child public key derived viaderiveUnhardenedMps. Mirrors the existing ECDSAsignRecoveryMpcV2pattern.Issue Number
WCI-397
Type of change
How Has This Been Tested?
Unit tests added in
modules/sdk-core/test/unit/bitgo/utils/tss/eddsa/eddsaMPCv2.tsunderdescribe('signRecoveryMpcV2'):nacl.sign.detached.verifyagainstderiveUnhardenedMpsfalse"EdDSA MPCv2 recovery signature verification failed"Run with: