fix(statics): remove stale eth:at bot token colliding with live AMS#8960
Closed
mmcshinsky-bitgo wants to merge 1 commit into
Closed
fix(statics): remove stale eth:at bot token colliding with live AMS#8960mmcshinsky-bitgo wants to merge 1 commit into
mmcshinsky-bitgo wants to merge 1 commit into
Conversation
The eth:at bot token (hoodi testnet, contract 0x0581ccdf2d9bca21baeff8b32b2551fd49cf70aa) in botTokens.ts is a generated snapshot of AMS that has drifted from the live AMS data: its symbol (at) no longer matches its fullName (APT), it sits in the mainnet eth: namespace despite being on hoodi testnet, and its contract collides with the live AMS-served token at the same address under a different name -- producing DuplicateContractAddressDefinitionError when statics + AMS are merged. It is referenced nowhere else in the SDK. Removing the orphaned snapshot entry is consistent with what generate-botTokens would now produce (the live record under its current name). The durable guard against this class of drift lands separately in the statics merge fix. CSHLD-976
Contributor
Author
|
Closing: The durable, statics-precedence-preserving fix stays in #8957 (statics coins are added first; a colliding AMS token is skipped). bitgo-retail #6934 keeps the UI resilient regardless. |
Closed
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses the follow-up in CSHLD-976: "Confirm whether the static
eth:atbot token (and AMS-served counterpart) is intended, or whether one side should be removed/renamed."What
Removes the
eth:atbot token frombotTokens.ts:Why this entry is the stale side
asset-metadata-servicegenerate-botTokens), added by the asset-metadata-bot in feat: PR from asset-metadata-service for token onboardings #8885 (@bitgo/statics@58.43.0).atno longer matches fullNameAPT, and it sits in the mainneteth:namespace though it lives on hoodi testnet (siblings usehteth:).DuplicateContractAddressDefinitionError.family+contract, so AMS holds exactly one record at that contract (the differently-named one) — meaning the staticseth:atis orphaned. Removing it is consistent with whatgenerate-botTokenswould now regenerate.Verification
grepconfirmseth:at/ the contract are gone frombotTokens.ts.tsc --buildclean,mocha test/unit/coins.ts→ 28764 passing (the 4 fewer vs. baseline areeth:at's auto-generated per-coin tests).Related
🤖 Generated with Claude Code