feat(sdk-coin-canton): forward token and make choiceArgument optional#8950
Merged
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates Canton transaction intent construction and Canton command typing to support token-aware routing and no-argument DAML choices.
Changes:
- Forward
tokenNameintocantonCommandintent creation so downstream systems can route mint/burn for Canton tokens sharing a base-coin wallet. - Make
CantonExerciseCommand.ExerciseCommand.choiceArgumentoptional to allow omitting it for no-argument choices.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
modules/sdk-core/src/bitgo/wallet/wallet.ts |
Forwards tokenName when building cantonCommand intents via prebuildTxWithIntent. |
modules/sdk-core/src/bitgo/utils/tss/baseTypes.ts |
Relaxes Canton exercise command typing by making choiceArgument optional. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
abhijeet848
changed the title
abhijeet848
requested review from
kisslove-dewangan,
mohammadalfaiyazbitgo and
ravibitgo
zeeshanamjad-eng
previously approved these changes
Jun 5, 2026
abhijeet848
changed the title
zeeshanamjad-eng
approved these changes
Jun 5, 2026
ravibitgo
approved these changes
Jun 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes:
Forward token to IMS.
Canton mint/burn commands are built server-side by IMS, which needs to know which token the command targets to resolve the registrar. A Canton token shares the base-coin wallet (tcanton), so the token cannot be inferred — it must be passed explicitly. The cantonCommand branch now forwards params.tokenName, which populateIntent maps to intent.token. Without this, IMS fails with token is required for choice context resolution.
Make choiceArgument optional.
No-argument Canton choices (e.g. CredentialOffer_AcceptFree) have an empty choiceArgument: {}. Mongoose minimize strips empty objects on persist, so rebuilding such a command forwards it to IMS without choiceArgument, which previously caused a 400. Making it optional here is the type-level half of the fix; IMS materializes {} before /prepare.
No change for existing flows — callers that don't pass tokenName are unaffected.
Ticket: SCAAS-9624