Restructure quality branch: rename state terms and update definitions#26
Merged
Restructure quality branch: rename state terms and update definitions#26
Conversation
…itions, add quality of axiom
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses points 4 and 9 (partial) of the review on OBOFoundry/OBOFoundry.github.io#2770.
Both reviewers flagged that the term label state (IDPO:0000089) is too broad. Similarly, material state, liquid-like state, disorder, order, etc. were flagged as needing more specific labels.
state (IDPO:0000089) was deprecated for being too general and semantically ambiguous.
The top of the quality hierarchy was modified to place condensate material state (IDPO:0000075) and protein structural state (IDPO:0000001) as direct children of BFO:quality.
Quality branch terms renamed to be self-explanatory.
Quality branch definitions transformed into Aristotelian form.
Logical axioms added
protein structural state (IDPO:0000001): quality_of some protein region (IDPO:0000095).
condensate material state (IDPO:0000075): quality_of some condensate (IDPO:0000092).
has initial state (IDPO_0000088) and has final state (IDPO_0000087) range modified to BFO:quality.