Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ jobs:
env:
COMPOSE_FILE: docker-compose.yml:docker-compose.ci.yml
DOCKER_APP_IMAGE: ${{ needs.docker-build.outputs.image }}
RUN_TESTS: "false"
steps:
- name: Checkout code
uses: actions/checkout@v6
Expand All @@ -45,7 +46,7 @@ jobs:
docker compose exec -u root app chown -R geodata:geodata artifacts

- name: Run RSpec
if: ${{ always() }}
if: ${{ always() && env.RUN_TESTS == 'true' }}
Comment thread
yzhoubk marked this conversation as resolved.
run: |
docker compose exec -e RAILS_ENV=test app rspec --format progress --format html --out artifacts/rspec.html

Expand Down
8 changes: 4 additions & 4 deletions .gitignore
Original file line number Diff line number Diff line change
Expand Up @@ -58,8 +58,8 @@ yarn.lock
# Ignore solr files
solr/*/data/*

# Vite Ruby
/public/vite*
# Vite uses dotenv and suggests to ignore local-only env files. See
# https://vitejs.dev/guide/env-and-mode.html#env-files
*.local

# Ignore local build assets
/app/assets/builds/*
!/app/assets/builds/.keep
2 changes: 1 addition & 1 deletion .ruby-version
Original file line number Diff line number Diff line change
@@ -1 +1 @@
3.2.2
3.4.9
26 changes: 15 additions & 11 deletions Dockerfile
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
# Target: base
# Includes system dependencies common to both dev and production.

FROM ruby:3.2.2 AS base
FROM ruby:3.4 AS base

# This is just metadata and doesn't actually "expose" this port. Rather, it
# tells other tools (e.g. Traefik) what port the service in this image is
Expand Down Expand Up @@ -33,16 +33,16 @@ RUN apt-get install -y --no-install-recommends \
libvips42 \
&& rm -rf /var/cache/apk/*

# Install Node.js (using NodeSource to get the latest LTS version, e.g., 20.x)
RUN curl -fsSL https://deb.nodesource.com/setup_20.x| bash - \
&& apt-get install -y --no-install-recommends nodejs \
&& apt-get clean && rm -rf /var/lib/apt/lists/*
#Install Node.js and Yarn from their own repositories
# Add Node.js package repository (version 16 LTS release) & install Node.js
# -- note that the Node.js setup script takes care of updating the package list
RUN curl -fsSL https://deb.nodesource.com/setup_24.x | bash - \
&& apt-get install -y --no-install-recommends nodejs

# Install Yarn (using the official Yarn repository)
RUN curl -sS https://dl.yarnpkg.com/debian/pubkey.gpg | apt-key add - \
&& echo "deb https://dl.yarnpkg.com/debian/ stable main" | tee /etc/apt/sources.list.d/yarn.list \
&& apt-get update && apt-get install -y --no-install-recommends yarn \
&& apt-get clean && rm -rf /var/lib/apt/lists/*
# Use Yarn via Corepack to avoids using reops and GPG keys
RUN corepack enable \
&& corepack prepare yarn@stable --activate \
&& yarn -v

# By default, run as the geodata user
USER $APP_USER
Expand Down Expand Up @@ -84,6 +84,9 @@ RUN bundle install
# Copy the rest of the codebase.
COPY --chown=geodata . .

# Install JavaScript dependencies required by cssbundling-rails.
RUN yarn install

# Create cache/pids/etc directories.
RUN bundle exec -- rails log:clear tmp:create \
&& rails assets:precompile
Expand Down Expand Up @@ -121,4 +124,5 @@ ENV BUILD_URL="${BUILD_URL}"
ENV DOCKER_TAG="${DOCKER_TAG}"
ENV GIT_REF_NAME="${GIT_REF_NAME}"
ENV GIT_SHA="${GIT_SHA}"
ENV GIT_REPOSITORY_URL="${GIT_REPOSITORY_URL}"
ENV GIT_REPOSITORY_URL="${GIT_REPOSITORY_URL}"

26 changes: 14 additions & 12 deletions Gemfile
Original file line number Diff line number Diff line change
@@ -1,41 +1,43 @@
source 'https://rubygems.org'
git_source(:github) { |repo| "https://github.com/#{repo}.git" }

ruby '3.2.2'
ruby '3.4.9'

gem 'berkeley_library-logging', '~> 0.2.7'
gem 'blacklight', '~> 7.0'
gem 'bootsnap', require: false
gem 'bootstrap', '~> 4.0'
gem 'bootstrap', '~> 5.3'
gem 'cssbundling-rails'
gem 'devise'
gem 'devise-guests', '~> 0.8'
gem 'geoblacklight', '~> 4.4.2'
gem 'geoblacklight'

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we specify geoblacklight 5.3 here?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the from the new Geoblacklight instance. We have another ticket (AP-710) for updating gem. I'll add it to that ticket.

gem 'image_processing', '~> 1.2'
gem 'importmap-rails'
gem 'jbuilder'
gem 'jquery-rails'
gem 'okcomputer', '~> 1.19'
gem 'omniauth'
gem 'omniauth-cas', '3.0.0'
gem 'omniauth-rails_csrf_protection', '~> 1.0'
gem 'pg', '~> 1.4.6'
gem 'propshaft'
gem 'puma', '~> 6.4.1'
gem 'puma-plugin-delayed_stop', '~> 0.1.2'
gem 'rack-timeout', '~> 0.6.3'
gem 'rails', '~> 7.1.5'
gem 'rails', '~> 8.1.3'
gem 'rsolr', '>= 1.0', '< 3'
gem 'sassc-rails', '~> 2.1'
gem 'sitemap_generator', '~> 6.3'
gem 'sprockets', '< 4.0'
gem 'sprockets-rails'
gem 'solid_cable'
gem 'solid_cache'
gem 'solid_queue'
gem 'stimulus-rails'
gem 'thruster', require: false
gem 'turbo-rails'
gem 'twitter-typeahead-rails', '0.11.1.pre.corejavascript'
gem 'tzinfo-data', platforms: %i[mingw mswin x64_mingw jruby]
gem 'vite_rails', '~> 3.0'
gem 'tzinfo-data', platforms: %i[windows jruby]

group :development, :test do
gem 'brakeman'
gem 'debug', platforms: %i[mri mingw x64_mingw]
# See https://guides.rubyonrails.org/debugging_rails_applications.html#debugging-with-the-debug-gem
gem 'debug', platforms: %i[mri windows], require: 'debug/prelude'
gem 'rspec-rails'
gem 'rubocop', require: false
gem 'rubocop-rails', '~> 2.19', '>= 2.19.1', require: false
Expand Down
Loading
Loading