CI: Add compile-only coverage for more conduits#16
Open
bonachea wants to merge 3 commits into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
As previously discussed, this PR expands compile-time coverage in CI to include:
ibv,ucx,ofiandmpion Linuxofiandmpion macOSCurrently most jobs are relying on an OpenMPI package for
mpi, which in most cases meansMPI_CCis backed by an OS-dependent compiler (which in general will differ$CC). However the current combinations all appear to be link-compatible and we're not running execution-time tests anyhow. Theicxconfigs instead use Intel MPI (with the matchingCC) that was already preinstalled in the container.Rough Job Performance Impact
Ubuntu jobs that previously would complete in 2.0..4.5 minutes now complete in 4.0..7.5 minutes
macOS jobs that previously would complete in 4.0..15.0 minutes now complete in 4.0..15.0 minutes
So Ubuntu jobs have gotten roughly 2-3 minutes longer.
macOS jobs have also gotten longer on average, but the "long tail" is still under 15 minutes.
In both cases, most of the slowdown is coming from the
make allandmake checksteps (which are now doing 2x or 3x more compilation and linking than before). But that's exactly where we're seeking to add coverage.