Skip to content

Fixes actions issues #487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
firestar300 wants to merge 3 commits into from
+66 −64
Closed

Fixes actions issues #487

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
5303dfb
chore: update composer.lock
firestar300 Apr 24, 2026
580bd54
ci: use Corepack for Yarn 4.5.0 instead of latest Berry
firestar300 Apr 24, 2026
2cb7436
fix(Share): phpcs issue
firestar300 Apr 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 4 additions & 2 deletions .github/workflows/node.js.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -21,9 +21,11 @@ jobs:
steps:
- uses: actions/checkout@v4
- name: Use Node.js ${{ matrix.node-version }}
uses: actions/setup-node@v1
uses: actions/setup-node@v4
with:
node-version: ${{ matrix.node-version }}
- run: yarn set version berry
cache: yarn
- name: Enable Corepack
run: corepack enable
Copy link
Copy Markdown

@cursor cursor Bot Apr 24, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corepack must be enabled before setup-node caching

High Severity

The cache: yarn option in actions/setup-node@v4 runs during the action step and tries to determine the Yarn cache directory. Because corepack enable runs after setup-node, the action uses the system's default Yarn v1.22.x, which conflicts with the "packageManager": "yarn@4.5.0" field in package.json. This is a well-documented issue (actions/setup-node#1027) that causes the CI step to fail. The corepack enable step needs to run before the actions/setup-node@v4 step that uses cache: yarn.

Fix in Cursor Fix in Web

Reviewed by Cursor Bugbot for commit 73351f9. Configure here.

- run: yarn
- run: yarn build
100 changes: 50 additions & 50 deletions composer.lock
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

24 changes: 12 additions & 12 deletions inc/Helpers/Formatting/Share.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,8 +54,8 @@ function get_share_link( string $name, string $link_to_share, array $share_attri
'href' => 'http://www.facebook.com/sharer.php',
'class' => 'share__link',
],
'icon' => 'social/facebook',
'params' => [
'icon' => 'social/facebook',
'params' => [
'u' => $link_to_share,
],
],
Expand All @@ -65,8 +65,8 @@ function get_share_link( string $name, string $link_to_share, array $share_attri
'href' => 'https://twitter.com/intent/tweet',
'class' => 'share__link',
],
'icon' => 'social/x',
'params' => [
'icon' => 'social/x',
'params' => [
'url' => $link_to_share,
],
],
Expand All @@ -76,8 +76,8 @@ function get_share_link( string $name, string $link_to_share, array $share_attri
'href' => 'https://www.linkedin.com/shareArticle',
'class' => 'share__link',
],
'icon' => 'social/linkedin',
'params' => [
'icon' => 'social/linkedin',
'params' => [
'url' => $link_to_share,
],
],
Expand All @@ -87,8 +87,8 @@ function get_share_link( string $name, string $link_to_share, array $share_attri
'href' => 'https://www.instagram.com/',
'class' => 'share__link',
],
'icon' => 'social/instagram',
'params' => [
'icon' => 'social/instagram',
'params' => [
'url' => $link_to_share,
],
],
Expand All @@ -98,8 +98,8 @@ function get_share_link( string $name, string $link_to_share, array $share_attri
'href' => 'https://bsky.app/intent/compose',
'class' => 'share__link',
],
'icon' => 'social/bluesky',
'params' => [
'icon' => 'social/bluesky',
'params' => [
'text' => $link_to_share,
],
],
Expand All @@ -109,8 +109,8 @@ function get_share_link( string $name, string $link_to_share, array $share_attri
'href' => 'mailto:',
'class' => 'share__link',
],
'icon' => 'social/email',
'params' => [
'icon' => 'social/email',
'params' => [
'body' => $link_to_share,
],
],
Expand Down
Loading