Fix is_daytime.json in datapack for 26.1 compatability#84
Open
Blake192 wants to merge 1 commit intoBPR02:26.1from
Open
Fix is_daytime.json in datapack for 26.1 compatability#84Blake192 wants to merge 1 commit intoBPR02:26.1from
Blake192 wants to merge 1 commit intoBPR02:26.1from
Conversation
Minecraft 26.1 requires a `clock` field for `minecraft:time_check`. Game was crashing before without the fix in the datapack.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This fixes a 26.1 compatibility issue in
skyvoid_vanilla_oneblock_starter.Minecraft 26.1 requires
minecraft:time_checkpredicates to include aclockfield. The currentis_daytime.jsonpredicate still uses the older format, which causes it to fail during datapack load and prevents the starter tick function from loading correctly.This PR updates the predicate to use:
which preserves the intended daytime check behavior while matching the 26.1 format.
Changed file
src/packs/extras/skyvoid_vanilla_oneblock_starter/data/skyvoid_vanilla_oneblock_starter/predicate/is_daytime.jsonError
When loading the datapacks on 26.1, the following errors appeared:
Why this matters
Without this change, the starter pack can partially fail to load on 26.1. In practice, the one-block worldgen can still appear to work, but starter-specific behavior does not initialize correctly because the predicate fails to parse and the starter tick function cannot load.
Testing
"clock": "minecraft:overworld"