Skip to content

Fix is_daytime.json in datapack for 26.1 compatability#84

Open
Blake192 wants to merge 1 commit intoBPR02:26.1from
Blake192:patch-1
Open

Fix is_daytime.json in datapack for 26.1 compatability#84
Blake192 wants to merge 1 commit intoBPR02:26.1from
Blake192:patch-1

Conversation

@Blake192
Copy link
Copy Markdown

Summary

This fixes a 26.1 compatibility issue in skyvoid_vanilla_oneblock_starter.

Minecraft 26.1 requires minecraft:time_check predicates to include a clock field. The current is_daytime.json predicate still uses the older format, which causes it to fail during datapack load and prevents the starter tick function from loading correctly.

This PR updates the predicate to use:

"clock": "minecraft:overworld"

which preserves the intended daytime check behavior while matching the 26.1 format.

Changed file

src/packs/extras/skyvoid_vanilla_oneblock_starter/data/skyvoid_vanilla_oneblock_starter/predicate/is_daytime.json

Error

When loading the datapacks on 26.1, the following errors appeared:

[Worker-Main-15/ERROR]: Couldn't parse data file 'skyvoid_vanilla_oneblock_starter:is_daytime' from 'skyvoid_vanilla_oneblock_starter:predicate/is_daytime.json': DataResult.Error['Failed to parse either. First: No key clock in MapLike[{"condition":"minecraft:time_check","value":{"min":0,"max":12000},"period":24000}]; Second: Not a json array: {"condition":"minecraft:time_check","value":{"min":0,"max":12000},"period":24000}']

[Render thread/ERROR]: Failed to load function skyvoid_vanilla_oneblock_starter:tick
java.util.concurrent.CompletionException: java.lang.IllegalArgumentException: Whilst parsing command on line 18: Can't find element 'skyvoid_vanilla_oneblock_starter:is_daytime' in registry 'minecraft:predicate' at position 64: ...is_daytime<--[HERE]

Why this matters

Without this change, the starter pack can partially fail to load on 26.1. In practice, the one-block worldgen can still appear to work, but starter-specific behavior does not initialize correctly because the predicate fails to parse and the starter tick function cannot load.

Testing

  • Reproduced the datapack load error on 26.1
  • Updated the predicate to include "clock": "minecraft:overworld"
  • Reloaded the datapack and confirmed the predicate/function load error no longer occurs and the oneblock vanilla starter pack functions properly

Minecraft 26.1 requires a `clock` field for `minecraft:time_check`. Game was crashing before without the fix in the datapack.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant