Migrate Valence Security Sentinel connector to CCF Push (Codeless Connector Framework)#14677
Open
shlomimatichin wants to merge 1 commit into
Open
Migrate Valence Security Sentinel connector to CCF Push (Codeless Connector Framework)#14677shlomimatichin wants to merge 1 commit into
shlomimatichin wants to merge 1 commit into
Conversation
…nector Framework) Migrates the Valence Security data connector to the Codeless Connector Framework (CCF) Push model: adds the DCR, poller config, connector definition, and ValenceAlerts/ValenceAuditLogs table definitions, bumps the solution package to 3.0.3, and registers ValenceSecurityCcfPush as a valid connector id. Resubmitted from a feature branch (rebased onto latest master) to replace PR Azure#14528, which was opened from the fork's master branch and tripped the idChangeValidator (head/base both named "master").
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Migrates the Valence Security Microsoft Sentinel connector from the legacy Log Analytics HTTP Data Collector (shared keys) pattern to a CCF Push connector using DCE/DCR + Azure Monitor Logs Ingestion API.
Changes:
- Replaces the legacy connector with a new
ValenceSecurity_PUSH_CCP/CCF Push connector definition, DCR, poller config, and table schemas. - Updates analytic rule + workbook queries to use the new
ValenceAlerts_CLschema and connector IDValenceSecurityCcfPush. - Regenerates solution package artifacts and updates solution versioning and validation connector IDs.
Reviewed changes
Copilot reviewed 14 out of 16 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Valence Security/Workbooks/ValenceAlertsWorkbook.json | Updates workbook KQL to reference ValenceAlerts_CL and new severity field. |
| Solutions/Valence Security/Package/testParameters.json | Adds/updates test parameters used by the regenerated ARM package. |
| Solutions/Valence Security/Package/mainTemplate.json | Major packaging update: new CCF Push connector resources, DCR/table deployment, updated versions/IDs. |
| Solutions/Valence Security/Package/createUiDefinition.json | Updates installer text/formatting and connector UI entries. |
| Solutions/Valence Security/Data/Solution_ValenceSecurity.json | Points solution data to the new CCF connector definition and bumps version. |
| Solutions/Valence Security/Data Connectors/ValenceSecurity_PUSH_CCP/ValenceSecurity_table_ValenceAuditLogs.json | Adds audit logs custom table schema definition. |
| Solutions/Valence Security/Data Connectors/ValenceSecurity_PUSH_CCP/ValenceSecurity_table_ValenceAlerts.json | Adds alerts custom table schema definition. |
| Solutions/Valence Security/Data Connectors/ValenceSecurity_PUSH_CCP/ValenceSecurity_connectorDefinition.json | Adds CCF connector definition (Customizable) with UI config, queries, and instructions. |
| Solutions/Valence Security/Data Connectors/ValenceSecurity_PUSH_CCP/ValenceSecurity_PollerConfig.json | Adds Push dataConnector (poller config) targeting the DCR stream. |
| Solutions/Valence Security/Data Connectors/ValenceSecurity_PUSH_CCP/ValenceSecurity_DCR.json | Adds DCR with two streams and transforms for TimeGenerated. |
| Solutions/Valence Security/Data Connectors/ValenceSecurity.json | Deletes the deprecated legacy Data Collector API connector. |
| Solutions/Valence Security/Analytic Rules/ValenceAlerts.yaml | Updates analytic rule to new connector ID, table, and field mappings; bumps rule version. |
| .script/tests/detectionTemplateSchemaValidation/ValidConnectorIds.json | Registers ValenceSecurityCcfPush as a valid connector ID for validations. |
| .script/tests/KqlvalidationsTests/CustomTables/ValenceAlerts_CL.json | Adds schema to support repo KQL validation tests for the new custom table. |
Comments suppressed due to low confidence (1)
Solutions/Valence Security/Package/mainTemplate.json:1
- Several ARM/packaging expressions appear malformed (missing closing
]]/]), which will cause template parsing/deployment failures. Please fix the bracket/quote balancing for these[[...]]expressions (e.g.,newGuid,concat(...), and theparameters(...)references underdcrConfig/auth) so they are syntactically valid for the packaging tool and downstream deployment.
{
Contributor
Author
|
done, its the same resolved comments from the previous PR (closed due to CI bug, nothing really changed) |
Contributor
|
Kindly review above comments. Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Migrate Valence Security Sentinel connector to CCF Push (Codeless Connector Framework)
Replaces the deprecated Log Analytics HTTP Data Collector API (Workspace ID + Primary Key) connector with a CCF Push connector using DCE/DCR-based auth via the Azure Monitor Logs Ingestion API. This follows Microsoft's deprecation of the sharedKeys-based connector pattern.
Changes:
Testing Completed: Yes — validated in a Microsoft Sentinel environment; KQL and YAML validation run locally.