-
Notifications
You must be signed in to change notification settings - Fork 1.6k
Add RequestSendType.ROUND_ROBIN for per-request IP round-robin #2202
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pavel-ptashyts
wants to merge
13
commits into
AsyncHttpClient:main
Choose a base branch
from
maygemdev:requests-round-robin-per-host
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
56d3bab
Add RequestSendType.ROUND_ROBIN for per-request IP round-robin
pavel-ptashyts 2e1712c
Merge branch 'main' into requests-round-robin-per-host
pavel-ptashyts 97873f5
Fix test for macOS case
pavel-ptashyts e9501ff
Some refactor
pavel-ptashyts 0754d3b
Merge branch 'AsyncHttpClient:main' into requests-round-robin-per-host
pavel-ptashyts de383cc
Add logging for in case of fallback to default RequestSendType type, …
pavel-ptashyts 031ddb1
Merge branch 'requests-round-robin-per-host' of https://github.com/ma…
pavel-ptashyts 8b7a9d8
Add limit for counters in RoundRobinAddressSelector
pavel-ptashyts b5dd3a4
Add test for RoundRobinAddressSelector for MAX_TRACKED_HOSTS
pavel-ptashyts 2c16c7c
Update logic of round robin for proxy(disabled).
pavel-ptashyts 0b97c0b
Update javadocs for ROUND_ROBIN logic
pavel-ptashyts 7d929a7
Remove unnessary sort in RoundRobinAddressSelector
pavel-ptashyts 23a2a8b
Add comments to NettyRequestSender resolveAddresses
pavel-ptashyts File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
69 changes: 69 additions & 0 deletions
69
client/src/main/java/org/asynchttpclient/RequestSendType.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,69 @@ | ||
| /* | ||
| * Copyright (c) 2026 AsyncHttpClient Project. All rights reserved. | ||
| * | ||
| * Licensed under the Apache License, Version 2.0 (the "License"); | ||
| * you may not use this file except in compliance with the License. | ||
| * You may obtain a copy of the License at | ||
| * | ||
| * http://www.apache.org/licenses/LICENSE-2.0 | ||
| * | ||
| * Unless required by applicable law or agreed to in writing, software | ||
| * distributed under the License is distributed on an "AS IS" BASIS, | ||
| * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| * See the License for the specific language governing permissions and | ||
| * limitations under the License. | ||
| */ | ||
| package org.asynchttpclient; | ||
|
|
||
| /** | ||
| * Controls how requests are dispatched to a host that resolves to several IP addresses. | ||
| * | ||
| * <p>Configured globally through {@link AsyncHttpClientConfig#getRequestSendType()}. | ||
| */ | ||
| public enum RequestSendType { | ||
|
|
||
| /** | ||
| * Default behavior. The address list returned by DNS is used in its natural order: a new | ||
| * connection always targets the first address and only falls back to the next one when a TCP | ||
| * connection attempt fails. Combined with connection pooling (keyed by host), this means that | ||
| * with keep-alive enabled essentially all traffic to a host stays on the first reachable IP. | ||
| * | ||
| * <p>To spread traffic across a host's IPs in this mode, configure a resolver that rotates its | ||
| * results, such as {@link io.netty.resolver.RoundRobinInetAddressResolver}; the client keeps | ||
| * targeting the first address, and the resolver is what varies which IP that is. | ||
| */ | ||
| DEFAULT, | ||
|
|
||
| /** | ||
| * Strict per-request round-robin across the host's resolved IPs. | ||
| * | ||
| * <p>For each request, the client rotates which resolved IP is targeted first (TCP failover to | ||
| * the remaining IPs is preserved) and makes connection reuse IP-aware, so that pooled HTTP/1.1 | ||
| * connections and multiplexed HTTP/2 connections are kept and reused per IP rather than per | ||
| * host. The net effect is that consecutive requests to a multi-IP host are spread evenly across | ||
| * all of its addresses, even when connections are kept alive. | ||
| * | ||
| * <p>Notes: | ||
| * <ul> | ||
| * <li>Has no effect for hosts that resolve to a single address, literal-IP hosts, requests | ||
| * with an explicit {@link Request#getAddress() address}, or requests routed through a | ||
| * proxy (HTTP or SOCKS) — the socket is established to the proxy, not directly to the | ||
| * rotated target IPs. (Round-robin still applies when the proxy is bypassed for the host.)</li> | ||
| * <li>Connection limits ({@code maxConnectionsPerHost}) remain per host, not per IP.</li> | ||
| * <li>The address order comes straight from the configured | ||
| * {@link io.netty.resolver.InetNameResolver}; this mode does not re-sort it. For the | ||
| * rotation to map consistently across requests, use a resolver that returns the addresses | ||
| * in a stable order and does not deliberately reorder them between resolutions (for | ||
| * example {@link io.netty.resolver.dns.DnsNameResolver}). Do not pair this mode with a | ||
| * resolver that intentionally rotates its results, such as | ||
| * {@link io.netty.resolver.RoundRobinInetAddressResolver} — that one is meant for | ||
| * {@link #DEFAULT} mode, where it provides the spreading instead.</li> | ||
| * <li>Rotation is not health-aware: it always cycles through every IP the resolver returns, so | ||
| * a temporarily unreachable IP keeps receiving its share of requests — each then retried | ||
| * via TCP failover to a healthy IP — until the resolver stops returning it. Which IPs are | ||
| * live is expected to be governed at the DNS/resolver level, as it already is in | ||
| * {@link #DEFAULT} mode.</li> | ||
| * </ul> | ||
| */ | ||
| ROUND_ROBIN | ||
| } |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Quietly falling back to DEFAULT when the value doesn't parse will hide typos in someone's config. A warning log that includes the bad value would make that a lot easier to spot.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fixed