fix(migrate): read SQLite UUIDs stored as text, not just blobs#38
Merged
Conversation
Exporting or copying from a real SQLite database failed with "invalid length: expected 16 bytes, found 36" when its UUID columns were stored as 36-character hyphenated text rather than 16-byte blobs — a format written by older toolchains. The reader decoded UUIDs strictly as blobs, so any such database was unreadable. When the source is SQLite, read each table through a query that coerces UUID columns back to blobs regardless of how they were stored (text is converted, blobs pass through untouched), so both formats decode. The write path already adapts to the destination, so every source/destination combination now produces a correct result, and importing a text-UUID database canonicalizes it in the process. Adds a regression test for text-stored UUIDs and an export/import matrix covering every SQLite/PostgreSQL source-destination pair.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Exporting or copying from a real SQLite database failed with "invalid length: expected 16 bytes, found 36" when its UUID columns were stored as 36-character hyphenated text rather than 16-byte blobs — a format written by older toolchains. The reader decoded UUIDs strictly as blobs, so any such database was unreadable.
When the source is SQLite, read each table through a query that coerces UUID columns back to blobs regardless of how they were stored (text is converted, blobs pass through untouched), so both formats decode. The write path already adapts to the destination, so every source/destination combination now produces a correct result, and importing a text-UUID database canonicalizes it in the process.
Adds a regression test for text-stored UUIDs and an export/import matrix covering every SQLite/PostgreSQL source-destination pair.