Skip to content

feat: upgrade to react-native 0.85.0 with RNTA 5.3.2#732

Merged
MeliValesca merged 8 commits into
AppAndFlow:mainfrom
hurali97:feat/upgrade-rn-85
Jun 25, 2026
Merged

feat: upgrade to react-native 0.85.0 with RNTA 5.3.2#732
MeliValesca merged 8 commits into
AppAndFlow:mainfrom
hurali97:feat/upgrade-rn-85

Conversation

@hurali97

@hurali97 hurali97 commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary

Note: Merge this PR before #733

This PR is required for the AGP v9 adoption. With this PR, we upgrade to RN 0.85.0 with RNTA at 5.3.2.

Test Plan

  • Verified locally, app builds and launches fine
  • However, while selecting an option from dev menu, there is an infinite loop. I investigated a little but couldn't find root cause. Help here from maintainers is appreciated.
See Video
upgrade.mov

@hurali97 hurali97 mentioned this pull request Jun 22, 2026
@MeliValesca

Copy link
Copy Markdown
Member

@hurali97 Thanks for the RN 0.85 upgrade!

I reproduced the Android restart loop. It was caused by a native Yoga crash in RNCSafeAreaViewShadowNode::adjustLayoutWithState, not by the dev menu itself.

The code was copying props.yogaStyle, modifying padding/margin on the copy, then replacing the whole Yoga node style. With RN 0.85/Yoga, that can hit a StyleValuePool assertion and abort the app. Since the selected example is persisted, the app restarts into the same crashing screen.

I pushed a fix that updates only the current Yoga node’s padding/margin values and marks it dirty when needed.

@hurali97

Copy link
Copy Markdown
Contributor Author

Hey @MeliValesca

Thanks for investigating and helping get this PR across the line. Appreciate it!

@MeliValesca MeliValesca merged commit 4d00f52 into AppAndFlow:main Jun 25, 2026
8 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants