Skip to content

fix: use underscores instead of hyphens in simulation table column names#247

Merged
aoustry merged 1 commit into
mainfrom
fix/column_names_simulation_table
Jul 13, 2026
Merged

fix: use underscores instead of hyphens in simulation table column names#247
aoustry merged 1 commit into
mainfrom
fix/column_names_simulation_table

Conversation

@Juliette-Gerbaux

@Juliette-Gerbaux Juliette-Gerbaux commented Jul 10, 2026

Copy link
Copy Markdown
Contributor

Process ID

Process: GP-02

Description

Renames the simulation table columns from hyphenated to underscored names, aligning naming conventions with antares_simulator and gems_view_builder:

  • absolute-time-index -> absolute_time_index
  • block-time-index -> block_time_index
  • scenario-index -> scenario_index
  • basis-status -> basis_status

Updated the SimulationColumns enum values, related docstrings/comments, and all tests/docs referencing these column names.

Impact Analysis

  • Affected module: simulation/ (simulation_table.py), plus associated unit and e2e tests and docs/user-guide/outputs.md.
  • No solver output values change - this only renames DataFrame column labels in the exported simulation table, not any computed results.

Checklist

  • Unit tests pass (pytest)
  • Type checking passes (mypy)
  • Formatting passes (black, isort)
  • pyproject.toml version bumped if applicable
  • AGENTS.md reviewed for impact and updated if needed

Column names like absolute-time-index or scenario-index are not valid
Python identifiers, which prevents attribute-style access on the
resulting DataFrame (e.g. via query() or itertuples()).

Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
@Juliette-Gerbaux
Juliette-Gerbaux requested a review from aoustry July 10, 2026 15:02
@aoustry
aoustry merged commit 0143a3d into main Jul 13, 2026
2 checks passed
@aoustry
aoustry deleted the fix/column_names_simulation_table branch July 13, 2026 10:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants