Skip to content

[PWGUD] add true gap service and TPC-FT0 correlations#16083

Merged
rolavick merged 13 commits intoAliceO2Group:masterfrom
Luzhiyongg:master
May 6, 2026
Merged

[PWGUD] add true gap service and TPC-FT0 correlations#16083
rolavick merged 13 commits intoAliceO2Group:masterfrom
Luzhiyongg:master

Conversation

@Luzhiyongg
Copy link
Copy Markdown
Contributor

No description provided.

Luzhiyongg and others added 9 commits May 4, 2026 13:36
This header file defines the Truegapside service outputs for the UPC analysis.
TPC-FT0 correlations
[PWGUD] Please consider the following formatting changes to AliceO2Group#16081
Removed unused UdTracksFull type alias and updated process function signature.
@github-actions github-actions Bot added the pwgud label May 4, 2026
@github-actions github-actions Bot changed the title add true gap service and TPC-FT0 correlations [PWGUD] add true gap service and TPC-FT0 correlations May 4, 2026
@github-actions
Copy link
Copy Markdown

github-actions Bot commented May 4, 2026

O2 linter results: ❌ 2 errors, ⚠️ 14 warnings, 🔕 0 disabled

[PWGUD] Please consider the following formatting changes to AliceO2Group#16083
Copy link
Copy Markdown
Collaborator

@rolavick rolavick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why do you need the UpcService? What is the usage of it?

@Luzhiyongg
Copy link
Copy Markdown
Contributor Author

Luzhiyongg commented May 4, 2026

Why do you need the UpcService? What is the usage of it?

Hi roman,
For event-mixing, it's required to put the major event selection in the filter, otherwise the event-mixing pairs will include many unused pairs and significantly reduce the statistics.
We found this issue in pp and it's expected that the case will be more significant in UPC.

As the major event selection here are gapside and truegapside, I create a service task to produce truegapside so that I can use truegapside in the filter.
UpcService.h is the header defining truegapside output, and it's included by the upcTrueGapService.cxx and flowLongRangeCorrUpc.cxx

@alibuild
Copy link
Copy Markdown
Collaborator

alibuild commented May 5, 2026

Error while checking build/O2Physics/o2 for b5c095c at 2026-05-05 03:06:

No log files found

Full log here.

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not really a service, it is just a table definition. Put this header to PWGUD/DataModel and change the name appropriatelly, that is xxxxTables.h. Also, be specific in \brief

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also, this only produces one desired table. Put the file to PWGUD/TableProducer. Change the appropriately, that is xxxxProducer.cxx

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

got it. I will do that

@rolavick rolavick enabled auto-merge (squash) May 6, 2026 09:03
@rolavick rolavick merged commit 3eb4bd6 into AliceO2Group:master May 6, 2026
13 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Development

Successfully merging this pull request may close these issues.

3 participants