[PWGHF/HFC] Adding initial setup for correlation and event mixing at MC truth level#16061
Draft
deependra170598 wants to merge 6 commits intoAliceO2Group:masterfrom
Draft
[PWGHF/HFC] Adding initial setup for correlation and event mixing at MC truth level#16061deependra170598 wants to merge 6 commits intoAliceO2Group:masterfrom
deependra170598 wants to merge 6 commits intoAliceO2Group:masterfrom
Conversation
|
O2 linter results: ❌ 0 errors, |
deependra170598
added a commit
to deependra170598/O2Physics
that referenced
this pull request
May 1, 2026
Please consider the following formatting changes to AliceO2Group#16061
deependra170598
force-pushed
the
hfc-mc-correlation
branch
from
e09e9bd to
5c4c3fb
Compare
vkucera
reviewed
May 5, 2026
| const auto groupedMcParticles = mcParticles.sliceBy(perCollisionCandMcGen, mcCollision.globalIndex()); | ||
| const auto groupedCollisions = collisions.sliceBy(collPerMcCollision, mcCollision.globalIndex()); | ||
|
|
||
| if (groupedCollisions.size() < 1) { |
Collaborator
There was a problem hiding this comment.
Does this not work?
Suggested change
| if (groupedCollisions.size() < 1) { | |
| if (groupedCollisions.empty()) { |
| PROCESS_SWITCH(HfCorrelatorDstarHadrons, processSeMcGen, "Process MC Gen same-event mode", false); | ||
|
|
||
| /// D*-Hadron correlation pair builder at MC Gen mixed-event level | ||
| void processMcGenME(McCollisionsWithMult const& collisions, |
Collaborator
There was a problem hiding this comment.
The two process functions have a very big overlap. Factor the common part out if possible to reduce the code duplication.
| /// \author Fabrizio Grosa <fabrizio.grosa@cern.ch>, CERN | ||
| /// \author Shyam Kumar <shyam.kumar@cern.ch> | ||
|
|
||
| /// \brief Task to strore correlations between D* and hadrons. |
Collaborator
There was a problem hiding this comment.
Suggested change
| /// \brief Task to strore correlations between D* and hadrons. | |
| /// \brief Task to store correlations between D* and hadrons. |
| } else { | ||
| efficiencyWeightDstar = vecHistEfficiencyDstar[0]->GetBinContent(vecHistEfficiencyDstar[0]->GetXaxis()->FindBin(ptDstar)); | ||
| if (!efficiencyWeightDstar) { | ||
| if (efficiencyWeightDstar == 0.0) { |
Collaborator
There was a problem hiding this comment.
Don't compare double values to 0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi @gluparel, @apalasciano and @singhra1994 !
In this PR, the most important changes are:
MC Gen Data Model Extensions:
DstarHadronMcGenPairfor D*-hadron MC Gen pairs andDstarHadronGenInfofor associated MC Gen information.MC Gen Pair Building Logic:
processSeMcGenandprocessMcGenMEfunctions incorrelatorDstarHadrons.cxxto build D*-hadron pairs at MC Gen same-event and mixed-event levels, respectively.MC Gen Histogramming in Analysis Task:
Work is in progress and let me know if any suggestion or changes are required. Thanks