Skip to content

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143

Open
NarrowsProjects wants to merge 134 commits intomainfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel
Open

[O2B-1555] Add normalize setter functions to all classes that extend filter model and selection model#2143
NarrowsProjects wants to merge 134 commits intomainfrom
impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 23, 2026 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • Setting filters will now display them in the url

Notable changes for developers:

  • All filters now have a normalized setter that will set the values of the filters based on the output of the normalize getter in query parameter form.

Changes made to the database:

  • N/A

Guust and others added 30 commits February 20, 2026 10:23
chore: remove redundant model assignment.
722caf7
chore: move all filters denoted as so to a filteringModel
f161cae
Make filterInputModel extend filterModel
9faffaf
rename inputfilter to ParsedInputFilter
247943b
implement authorfilter with ParsedInputFilterModel changes
114285d
re-implement filter
f39f7ae
add tag-filters to the filtering object
df1fea3
replace titleFilter and contentFilter with RawTextFilterModels
96ca85f
make Authorfilter an implementation of RawTextFilterModel
93b3291
add runs filter to the filteringmodel
5a5e830
add environments filter to the filteringmodel
b5e7148
add lhcFills filter to the filteringmodel
3507ba0
add created filter to the filteringmodel
9c63409
move the sort 'filter' to fetchlogs, since it doesn't actually filter…
5500b3e 
… anything
change filter to rawTextFilter for title
a09ae8b
fix test by changing event type to 'change'
512999b
fix content and author tests
0f15812
import openFilteringPanel and resetFilters
7b641ca
fix createdAt filter test
5ab8218
change event types to change
4c96d73
fix isAnyFilterActive
18ce4dc
remove _raw as from authorfilterModel, as it serves no purpose
685dd38
chore: removed ParsedInputFilterModel
4e132fd
chore: add toLowerCase to filterQueryParam computation
caf9812
@NarrowsProjects
[O2B-1530] Lhc fills add sb duration filter (#2080)
41c5a72 
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
@isaachilly
[O2B-1544] Fix pagination for filtered envs and add a test (#2096)
f38f597 
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
remove the combination operator from runs
3efdf1d
remove the combination operator from envirionments
fc61bea
remove the combination operator from lhcFills
9c4df68
make filter computation much more compact using filteringmodel.normalize
b860320
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 5 times, most recently from f987806 to b1dc463 Compare April 23, 2026 18:32
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 6 times, most recently from e540f27 to edb626f Compare April 27, 2026 07:04
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 4a30d27 to ae6c287 Compare April 27, 2026 07:17
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch 2 times, most recently from 88cc4f4 to 49ed030 Compare April 27, 2026 07:36
NarrowsProjects added 5 commits May 4, 2026 18:10
chore: undo de-rowification
3390e10
Merge branch 'improv/O2B-1557/Force-all-filters-managed-by-FilteringM…
38aa69d 
…odel-to-extend-FilterModel-or-SelectionModel' into feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url
Merge branch 'main' into feature/O2B-1556/Configure-FilteringModel-ob…
1d173f4 
…servability-to-set-active-filters-to-the-url
add pageIdentifier setter and router getter back
90e1911
add mcreproducable toggle back to test
f1bb637
Base automatically changed from feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url to main May 5, 2026 10:02
@NarrowsProjects NarrowsProjects force-pushed the impov/O2B-1555/Add-normalize-setter-functions-to-all-classes-that-extend-FilterModel-and-SelectionModel branch from 49ed030 to 85beaac Compare May 5, 2026 10:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta Awaiting requested review from graduta graduta is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@NarrowsProjects @isaachilly