Skip to content

[O2B-1556] Configure filtering model observability to set active filters to the url#2142

Merged
graduta merged 128 commits intomainfrom
feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url
May 5, 2026
Merged

[O2B-1556] Configure filtering model observability to set active filters to the url#2142
graduta merged 128 commits intomainfrom
feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 21, 2026 •
edited
Loading

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • When configuring a filter a string version will then appear in the URL

Notable changes for developers:

  • FilteringModel now has a router argument for its constructor.
  • All pages that use a filteringModel must explicitly set filteringModel.pageIdentifier. This identifier determines if this specific filteringModel instance should sync its active filters to the URL, and which page’s URL should be used to initialize the filter values for that filteringModel.
    • This is currently done by passing the identifier page identifier via the constructor
  • All overview page reset() functions have gained a clearUrl boolean argument, that determines if running the reset function should also remove the filters from the url.

Changes made to the database:

  • N/A

Guust and others added 30 commits February 20, 2026 10:23
chore: remove redundant model assignment.
722caf7
chore: move all filters denoted as so to a filteringModel
f161cae
Make filterInputModel extend filterModel
9faffaf
rename inputfilter to ParsedInputFilter
247943b
implement authorfilter with ParsedInputFilterModel changes
114285d
re-implement filter
f39f7ae
add tag-filters to the filtering object
df1fea3
replace titleFilter and contentFilter with RawTextFilterModels
96ca85f
make Authorfilter an implementation of RawTextFilterModel
93b3291
add runs filter to the filteringmodel
5a5e830
add environments filter to the filteringmodel
b5e7148
add lhcFills filter to the filteringmodel
3507ba0
add created filter to the filteringmodel
9c63409
move the sort 'filter' to fetchlogs, since it doesn't actually filter…
5500b3e 
… anything
change filter to rawTextFilter for title
a09ae8b
fix test by changing event type to 'change'
512999b
fix content and author tests
0f15812
import openFilteringPanel and resetFilters
7b641ca
fix createdAt filter test
5ab8218
change event types to change
4c96d73
fix isAnyFilterActive
18ce4dc
remove _raw as from authorfilterModel, as it serves no purpose
685dd38
chore: removed ParsedInputFilterModel
4e132fd
chore: add toLowerCase to filterQueryParam computation
caf9812
@NarrowsProjects
[O2B-1530] Lhc fills add sb duration filter (#2080)
41c5a72 
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
@isaachilly
[O2B-1544] Fix pagination for filtered envs and add a test (#2096)
f38f597 
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
remove the combination operator from runs
3efdf1d
remove the combination operator from envirionments
fc61bea
remove the combination operator from lhcFills
9c4df68
make filter computation much more compact using filteringmodel.normalize
b860320
github-code-quality[bot]
github-code-quality Bot found potential problems Apr 23, 2026
View reviewed changes
Comment thread test/public/Filters/filtersToUrl.test.js Fixed
Comment thread test/public/Filters/filtersToUrl.test.js Fixed
@NarrowsProjects NarrowsProjects changed the base branch from main to improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel April 23, 2026 12:06
@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 04ce63d to cbd335d Compare April 23, 2026 14:31
NarrowsProjects
NarrowsProjects commented Apr 23, 2026
View reviewed changes
Comment thread test/public/defaults.js
module.exports.fillInput = async (page, inputSelector, value, events = ['input']) => {
await page.waitForSelector(inputSelector);
await page.evaluate((inputSelector, value, events) => {
await page.waitForFunction((inputSelector, value, events) => {
Copy link
Copy Markdown
Collaborator Author

@NarrowsProjects NarrowsProjects Apr 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To the reviewers:
This is a stealth fix for a problem that happens for a couple of tests occasionally:

     TypeError: Cannot set properties of null (setting 'value')
      at evaluate (evaluate at module.exports.fillInput (test/public/defaults.js:671:16), <anonymous>:2:22)

This happens because between waitForSelector and the evaluate the selector ceases to be valid.
The waitForFunction guard is more more robust waitForSelector in this scenario.

As this PR adds tests that make back-to-back use of fillInput I thought it appropriate to add it here.

@NarrowsProjects NarrowsProjects force-pushed the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch from 4a30d27 to ae6c287 Compare April 27, 2026 07:17
NarrowsProjects added 2 commits May 4, 2026 18:10
chore: undo de-rowification
3390e10
Merge branch 'improv/O2B-1557/Force-all-filters-managed-by-FilteringM…
38aa69d 
…odel-to-extend-FilterModel-or-SelectionModel' into feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url
Base automatically changed from improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel to main May 4, 2026 17:41
graduta
graduta approved these changes May 5, 2026
View reviewed changes
Copy link
Copy Markdown
Member

@graduta graduta left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it would be good if we also move away from page identifiers as hard-coded strings and use a map/enum for this. Could you please create a ticket so that we do not forget about this?

@graduta graduta merged commit ca5d12b into main May 5, 2026
56 of 59 checks passed
@graduta graduta deleted the feature/O2B-1556/Configure-FilteringModel-observability-to-set-active-filters-to-the-url branch May 5, 2026 10:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@graduta graduta graduta approved these changes

+1 more reviewer

@github-code-quality github-code-quality[bot] github-code-quality[bot] left review comments

Reviewers whose approvals may not affect merge requirements

Assignees

@NarrowsProjects NarrowsProjects

Labels

frontend javascript Pull requests that update Javascript code

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NarrowsProjects @graduta @isaachilly