Skip to content

[O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel#2141

Merged
graduta merged 89 commits intomainfrom
improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel
May 4, 2026
Merged

[O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel#2141
graduta merged 89 commits intomainfrom
improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel

Conversation

@NarrowsProjects
Copy link
Copy Markdown
Collaborator

@NarrowsProjects NarrowsProjects commented Apr 21, 2026

…del or SelectionModel

I have a JIRA ticket

  • branch and/or PR name(s) include(s) JIRA ID
  • issue has "Fix version" assigned
  • issue "Status" is set to "In review"
  • PR labels are selected

Notable changes for users:

  • N/A

Notable changes for developers:

  • Now all put into the filtering model must extend SelectionModel or FilterModel

Changes made to the database:

  • N/A

Guust and others added 30 commits February 20, 2026 10:23
* Filtering by stableBeamsStart and stableBeamsEnd has been added to LHC Fills overview page
* lhcFills endpoint & DTO validation modified and testing added for the aforementioned changes
---------

Co-authored-by: GuustMetz <guust.metz@cern.ch>
Co-authored-by: Guust <metzguust@gmail.com>
* Replaced the two-query pattern with a single queryBuilder in GetAllEnvironmentsUseCase. The previous approach was redundant following Sequelize performance improvements; furthermore, the original implementation's logic was flawed which resulted in the pagination bug.
NarrowsProjects and others added 18 commits April 15, 2026 18:07
…y to only notify when notBadFraction is not empty.
@NarrowsProjects NarrowsProjects self-assigned this Apr 21, 2026
@NarrowsProjects NarrowsProjects added frontend javascript Pull requests that update Javascript code labels Apr 21, 2026
@NarrowsProjects NarrowsProjects changed the title chore: force all filters managed by FilteringModel to extend FilterMo… [O2B-1557] Force all filters managed by FilteringModel to extend FilterModel or SelectionModel Apr 21, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 21, 2026

Codecov Report

❌ Patch coverage is 0% with 5 lines in your changes missing coverage. Please review.
✅ Project coverage is 46.01%. Comparing base (58563b2) to head (3390e10).
⚠️ Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...public/components/Filters/common/FilteringModel.js 0.00% 5 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #2141      +/-   ##
==========================================
+ Coverage   45.84%   46.01%   +0.17%     
==========================================
  Files        1036     1036              
  Lines       17131    17131              
  Branches     3110     3111       +1     
==========================================
+ Hits         7853     7883      +30     
+ Misses       9278     9248      -30     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

Base automatically changed from improv/O2B-1552/Move-ad-hoc-filters-inside-runsOverviewModel-to-filteringModel to main May 4, 2026 16:01
@graduta graduta merged commit cd02894 into main May 4, 2026
24 of 25 checks passed
@graduta graduta deleted the improv/O2B-1557/Force-all-filters-managed-by-FilteringModel-to-extend-FilterModel-or-SelectionModel branch May 4, 2026 17:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

frontend javascript Pull requests that update Javascript code

Development

Successfully merging this pull request may close these issues.

3 participants