ci(nightly): don't gate the nightly feed on the flaky Intel leg#2264
Closed
harshitsinghbhandari wants to merge 1 commit into
Closed
ci(nightly): don't gate the nightly feed on the flaky Intel leg#2264harshitsinghbhandari wants to merge 1 commit into
harshitsinghbhandari wants to merge 1 commit into
Conversation
The Intel macOS leg fails transiently (notary -1009, osx-sign keychain race: code object is not signed at all). With publish-feed needing release-intel, every such flake skipped the whole nightly feed, so all recent nightlies shipped no nightly-mac.yml and the nightly channel 404d. Revert nightly publish-feed to needs: [guard, release] (its pre-AgentWrapper#2244 state). arm64/win/linux nightlies now publish daily regardless of Intel; feed.mjs still includes the x64 entry when the Intel leg finishes in time. The stable release stays gated on Intel (manual, re-runnable, verified). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Collaborator
Author
|
Superseded by the retry fix: the flakiness is general (the -1009 notary error hit macos-latest/arm64, not Intel), so decoupling only the Intel leg doesn't address it and drops the x64-in-feed guarantee. Retrying the publish step on all macOS legs fixes the root cause instead. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Every recent nightly failed, so the nightly update channel 404s (
nightly-mac.ymlnot found). Root cause:publish-feedwas set toneeds: [guard, release, release-intel], so any Intel-leg hiccup skips the entire nightly feed, for all platforms.The Intel macOS leg is genuinely flaky:
-1009 "connection offline"reaching Apple, andosx-signkeychain races →Agent Orchestrator.app: code object is not signed at all.Both pass on re-run, but a daily, unattended nightly shouldn't need a manual re-run to publish anything.
Fix
Revert nightly's
publish-feedtoneeds: [guard, release](its pre-#2244 state):feed.mjsstill includes the x64 entry when the Intel leg finishes in time (best-effort).The stable release stays gated on Intel , it's manual, re-runnable, and verified, so guaranteeing x64 in the stable feed is worth the gate there. Different reliability needs: stable = correctness, nightly = resilience.
🤖 Generated with Claude Code