fix: hooks not working on free version#2075
Conversation
Greptile SummaryThis PR fixes the Cordova post-process hooks ( Confidence Score: 4/5Safe to merge; the core fix is correct and only P2 quality issues remain. The fix correctly addresses the root cause (hardcoded package path), and the System.java change is a sound improvement. Only two P2 findings exist: a slightly fragile id regex and a missing guard that produces a confusing error message when config.xml is absent. Neither affects the happy-path behavior. hooks/post-process.js — regex and error-handling in getPackageName() Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[post-process.js runs] --> B[getPackageName]
B --> C{config.xml exists?}
C -- Yes --> D[Match widget id attribute]
C -- No --> E[throw — caught by caller]
D --> F{Match found?}
F -- Yes --> G[packageName from config.xml]
F -- No --> H[fallback: com.foxdebug.acode]
G & H --> I[Build MainActivity.java path]
I --> J[enableStaticContext patches MainActivity]
I --> K[enableKeyboardWorkaround patches MainActivity]
K --> L[SoftInputAssist injected into onCreate]
M[System.java initialize] -. removed .-> N[new SoftInputAssist activity]
Reviews (1): Last reviewed commit: "fix: hooks not working on free version" | Re-trigger Greptile |
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
83b1000
into
Acode-Foundation:ajit/fix-fetch-auth-config
No description provided.