feat: fix a11y issues in loader component#661
Open
fateeand wants to merge 4 commits into
Open
Conversation
fateeand
requested review from
TerranceKhumalo-absa,
korel-san and
lukasmatta
as code owners
Contributor
Coverage report for library
Test suite run success1346 tests passing in 38 suites. Report generated by 🧪jest coverage report action from c882c24 |
Contributor
Playwright test results
Details
|
korel-san
reviewed
Jun 10, 2026
Comment on lines
+41
to
+48
| setTimeout(() => { | ||
| el.textContent = message; | ||
| if (durationMs > 0) { | ||
| const timer = setTimeout(() => (el.textContent = ''), durationMs); | ||
| if (isAssertive) this._assertiveTimer = timer; | ||
| else this._politeTimer = timer; | ||
| } | ||
| }); |
Collaborator
There was a problem hiding this comment.
@fateeand It seems announce() schedules the message write on the next tick, but clear() only cancels the later clear timer. Calling clear() immediately after announce() can still leave the message announced. Possible solution: track the pending write timeout separately and cancel it in announce(), clear(), and ngOnDestroy()
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixing accessibility issues in loader component
Validation rules:
Validated using Playwright accessibility tests, Lighthouse tool, and manual checks including keyboard tab navigation and screen reader testing.
Full doc with rules
Checklist
[N/A] Keyboard Navigation
All interactive elements are fully operable via keyboard only, including buttons, inputs, menus, dialogs, sliders, drag-and-drop, tree views, multi-selects, and composite widgets. No traps or dead ends.
[N/A] Focus Management
Focus is visible, logical, moves in predictable order, trapped where necessary (modals/popovers), and restored after closing. Focus is perceivable in all interactive widgets.
Semantics / ARIA
Color / Contrast
Screen Reader / Assistive Technology
Responsive & Zoom
[N/A] Error Handling
Dynamic Content / Updates
[N/A] Interaction Feedback / States
[N/A] Authentication & Sensitive Actions
[N/A] Predictable & Controllable UI
Additional changes
Introduced
CpsLiveAnnouncerServiceto provide accessible live-region announcements independently of any specific component's live region. The initial use case is announcing that loading has completed when the loader component is destroyed. More broadly, this service offers a centralized solution for future accessibility announcements that are not naturally associated with a particular UI element.Release notes: