Skip to content

perf: 给登陆流水线加个超时#264

Draft
HarcoChen wants to merge 1 commit into
devfrom
codex/maaendmaslogin
Draft

perf: 给登陆流水线加个超时#264
HarcoChen wants to merge 1 commit into
devfrom
codex/maaendmaslogin

Conversation

@HarcoChen

@HarcoChen HarcoChen commented Jun 24, 2026

Copy link
Copy Markdown
Contributor

Motivation

  • Prevent premature failures or hangs during account switching and dropdown interactions by giving those steps more time to complete.

Description

  • Added "timeout": 60000 to the 切换账号-账号密码切换[EndFieldPC] node.
  • Added "timeout": 60000 to the 切换账号-展开下拉框[EndFieldPC] node.
  • Added "timeout": 60000 to the 切换账号-下拉框切换[EndFieldPC] node.
  • Added a newline at end of res/MaaFW/pipeline/EndFieldPC.json.

Testing

  • Ran JSON linting/validation (jq) against the modified file and it succeeded.
  • Ran the pipeline JSON schema validation and existing CI pipeline tests, which completed successfully.

Codex Task

Summary by Sourcery

在 EndFieldPC 流水线中,为账号切换和下拉菜单步骤增加超时时间,以减少过早失败的情况,并在该流水线的 JSON 文件末尾添加一个换行符。

Original summary in English

Summary by Sourcery

Increase timeouts for account-switch and dropdown steps in the EndFieldPC pipeline to reduce premature failures and add a trailing newline to the pipeline JSON file.

@sourcery-ai

sourcery-ai Bot commented Jun 24, 2026

Copy link
Copy Markdown
Reviewer's guide (collapsed on small PRs)

审查者指南

此 PR 通过在流水线 JSON 中为账号切换和下拉框相关节点添加 60 秒超时时间,并在文件末尾补充换行符以规范格式,从而提升了 EndFieldPC 流水线的鲁棒性。

文件层面的变更

Change Details Files
为 EndFieldPC 流水线中关键的账号切换和下拉交互节点配置了 60 秒超时时间,并统一了文件格式。
  • 为 切换账号-账号密码切换[EndFieldPC] 节点添加了 60000 ms 的超时字段,以允许更长时间的基于凭据的账号切换。
  • 为 切换账号-展开下拉框[EndFieldPC] 节点添加了 60000 ms 的超时字段,使下拉展开在失败前可等待最长 60 秒。
  • 为 切换账号-下拉框切换[EndFieldPC] 节点添加了 60000 ms 的超时字段,以延长下拉选择变化的允许持续时间。
  • 确保 EndFieldPC 流水线 JSON 文件以换行符结尾,以提升格式与工具兼容性。
res/MaaFW/pipeline/EndFieldPC.json

Tips and commands

与 Sourcery 交互

  • 触发一次新审查: 在拉取请求中评论 @sourcery-ai review
  • 继续讨论: 直接回复 Sourcery 的审查评论。
  • 从审查评论生成 GitHub issue: 通过回复某条审查评论,请求 Sourcery 基于该评论创建 issue。你也可以在审查评论下回复 @sourcery-ai issue 来创建对应的 issue。
  • 生成拉取请求标题: 在拉取请求标题中的任意位置写上 @sourcery-ai,即可在任何时候生成标题。你也可以在拉取请求中评论 @sourcery-ai title 来(重新)生成标题。
  • 生成拉取请求摘要: 在拉取请求正文中的任意位置写上 @sourcery-ai summary,即可在任意需要的位置生成 PR 摘要。你也可以在拉取请求中评论 @sourcery-ai summary 来(重新)生成摘要。
  • 生成审查者指南: 在拉取请求中评论 @sourcery-ai guide,即可在任何时候(重新)生成审查者指南。
  • 批量解决所有 Sourcery 评论: 在拉取请求中评论 @sourcery-ai resolve,即可将所有 Sourcery 评论标记为已解决。如果你已经处理完所有评论且不希望继续看到它们时,这会很有帮助。
  • 忽略所有 Sourcery 审查: 在拉取请求中评论 @sourcery-ai dismiss,即可忽略所有现有的 Sourcery 审查。尤其在你希望从一次全新的审查开始时非常有用——别忘了再评论 @sourcery-ai review 来触发新的审查!

自定义你的使用体验

访问你的 dashboard 可以:

  • 启用或禁用审查功能,例如 Sourcery 生成的拉取请求摘要、审查者指南等。
  • 更改审查语言。
  • 添加、移除或编辑自定义审查说明。
  • 调整其他审查设置。

获取帮助

Original review guide in English
Reviewer's guide (collapsed on small PRs)

Reviewer's Guide

This PR increases robustness of the EndFieldPC pipeline by adding 60-second timeouts to the account-switch and dropdown-related nodes in the pipeline JSON and normalizing the file formatting with a trailing newline.

File-Level Changes

Change Details Files
Configured 60-second timeouts for key account-switch and dropdown interaction nodes in the EndFieldPC pipeline and normalized file formatting.
  • Added a 60000 ms timeout field to the 切换账号-账号密码切换[EndFieldPC] node to allow longer credential-based account switching.
  • Added a 60000 ms timeout field to the 切换账号-展开下拉框[EndFieldPC] node so dropdown expansion waits up to 60 seconds before failing.
  • Added a 60000 ms timeout field to the 切换账号-下拉框切换[EndFieldPC] node to extend the allowed duration for dropdown selection changes.
  • Ensured the EndFieldPC pipeline JSON file ends with a newline for formatting and tooling compatibility.
res/MaaFW/pipeline/EndFieldPC.json

Tips and commands

Interacting with Sourcery

  • Trigger a new review: Comment @sourcery-ai review on the pull request.
  • Continue discussions: Reply directly to Sourcery's review comments.
  • Generate a GitHub issue from a review comment: Ask Sourcery to create an
    issue from a review comment by replying to it. You can also reply to a
    review comment with @sourcery-ai issue to create an issue from it.
  • Generate a pull request title: Write @sourcery-ai anywhere in the pull
    request title to generate a title at any time. You can also comment
    @sourcery-ai title on the pull request to (re-)generate the title at any time.
  • Generate a pull request summary: Write @sourcery-ai summary anywhere in
    the pull request body to generate a PR summary at any time exactly where you
    want it. You can also comment @sourcery-ai summary on the pull request to
    (re-)generate the summary at any time.
  • Generate reviewer's guide: Comment @sourcery-ai guide on the pull
    request to (re-)generate the reviewer's guide at any time.
  • Resolve all Sourcery comments: Comment @sourcery-ai resolve on the
    pull request to resolve all Sourcery comments. Useful if you've already
    addressed all the comments and don't want to see them anymore.
  • Dismiss all Sourcery reviews: Comment @sourcery-ai dismiss on the pull
    request to dismiss all existing Sourcery reviews. Especially useful if you
    want to start fresh with a new review - don't forget to comment
    @sourcery-ai review to trigger a new review!

Customizing Your Experience

Access your dashboard to:

  • Enable or disable review features such as the Sourcery-generated pull request
    summary, the reviewer's guide, and others.
  • Change the review language.
  • Add, remove or edit custom review instructions.
  • Adjust other review settings.

Getting Help

@HarcoChen HarcoChen changed the title Add 60s timeouts to account-switch and dropdown steps in EndFieldPC pipeline perf: 给登陆流水线加个超时 Jun 24, 2026

@sourcery-ai sourcery-ai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗨,我已经审查了你的更改,看起来非常不错!


Sourcery 对开源项目是免费的——如果你喜欢我们的审查,请考虑分享 ✨
帮我变得更有用!请在每条评论上点 👍 或 👎,我会根据你的反馈改进你的审查。
Original comment in English

Hey - I've reviewed your changes and they look great!


Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.

@HarcoChen HarcoChen marked this pull request as draft June 24, 2026 12:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant