Skip to content

Use bitcoin-lib 0.48#3316

Merged
sstone merged 1 commit into
masterfrom
update-bitcoin-lib
Jul 8, 2026
Merged

Use bitcoin-lib 0.48#3316
sstone merged 1 commit into
masterfrom
update-bitcoin-lib

Conversation

@sstone

@sstone sstone commented Jun 1, 2026

Copy link
Copy Markdown
Member

bitcoin-lib 0.48 includes some API changes: some static methods in DeterminsticWallets have been removed, users should call instance methods instead

See ACINQ/bitcoin-lib#108

@sstone
sstone force-pushed the update-bitcoin-lib branch 2 times, most recently from ed53720 to fa8c465 Compare June 3, 2026 07:25
@codecov-commenter

codecov-commenter commented Jun 3, 2026

Copy link
Copy Markdown

⚠️ Please install the 'codecov app svg image' to ensure uploads and comments are reliably processed by Codecov.

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 88.71%. Comparing base (129df36) to head (fa8c465).
⚠️ Report is 32 commits behind head on master.
❗ Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files
@@            Coverage Diff             @@
##           master    #3316      +/-   ##
==========================================
+ Coverage   88.67%   88.71%   +0.03%     
==========================================
  Files         221      222       +1     
  Lines       21453    21748     +295     
  Branches      832      873      +41     
==========================================
+ Hits        19023    19293     +270     
- Misses       2430     2455      +25     
Files with missing lines Coverage Δ
...air/crypto/keymanager/LocalOnChainKeyManager.scala 86.11% <100.00%> (ø)

... and 12 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@sstone
sstone force-pushed the update-bitcoin-lib branch from fa8c465 to 8b60f66 Compare July 6, 2026 13:28
@sstone
sstone force-pushed the update-bitcoin-lib branch from 8b60f66 to 84f46b5 Compare July 8, 2026 07:29
@sstone
sstone marked this pull request as ready for review July 8, 2026 07:40
@sstone
sstone merged commit 743dcdd into master Jul 8, 2026
1 check passed
@sstone
sstone deleted the update-bitcoin-lib branch July 8, 2026 07:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants