Add SUBSPACE_CLIENT_NAMESERVERS for custom client DNS#3
Merged
Conversation
Port of upstream subspacecommunity#223. When SUBSPACE_CLIENT_NAMESERVERS is set to a comma-separated list, that list is written verbatim into the generated client config's DNS line, overriding the default gateway DNS (and SUBSPACE_DISABLE_DNS) when present. Behavior is unchanged when the variable is unset. Co-Authored-By: Daniel Ekman <daniel@33k.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Custom client nameservers
Ports upstream subspacecommunity/subspace#223 into the fork so it lives in git rather than as a local container modification.
What it does
Adds a
SUBSPACE_CLIENT_NAMESERVERSenv var. When set to a comma-separated list (e.g.8.8.8.8,1.1.1.1), that value is written verbatim as theDNS =line in each newly generated client config.Precedence (validated by rendering the template across all branches)
CLIENT_NAMESERVERSsetDNS = <list>DISABLE_DNS=1DNS = <list>(nameservers win)DISABLE_DNS=1, no nameserversDNSline (unchanged)Notes
.conffiles are untouched until regenerated.false, which was misleading for a list-valued variable.docker build(compiles clean on the current master with the merged build fix).