refactor(proto): deprecate tonic-prost generated gRPC server types #2263
Merged
kkovaacs merged 4 commits intoJun 18, 2026
Conversation
Instead of directly using the `tonic_prost_build` generated server structs this change adds a per-server `server()` method returning a service instance that can be used in our Tonic server setup.
sergerad
approved these changes
Jun 17, 2026
Mirko-von-Leipzig
approved these changes
Jun 18, 2026
Mirko-von-Leipzig
left a comment
Mirko-von-Leipzig
left a comment
Collaborator
There was a problem hiding this comment.
Naming suggestion but LGTM.
…ed module This allows for removing the rewriting of the tonic-prost-build generated server module.
kkovaacs
deleted the
krisztian/grpc-hide-tonic-prost-server-implementation
branch
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
This PR introduces public server facade helpers under
miden_node_proto::serverand migrates node components away from directly constructing tonic-prost generated*Servertypes such asApiServerandWorkerStatusApiServer.The proto build now generates, for each service, a
server(service)constructor returning an opaque tower service and aservice_name()helper for health reporting. The underlying tonic-prost generated server structs remain available for compatibility, but are now marked deprecated with a note directing callers to usemiden_node_proto::serverinstead. Internal generated code and facade helpers suppress those deprecation warnings so preferred usage remains warning-free.Runtime server setup in RPC, NTX builder, validator, and remote prover now registers services via the new facade helpers. Health reporting was updated to use generated service names instead of naming concrete tonic server wrapper types. Tests that constructed generated server wrappers were updated to use the facade path, and validator tests now call generated facade method traits directly where appropriate.
Closes #1974
Changelog