Skip to content

fix: show invalid credentials error on login screens [WPB-14814]#4903

Merged
Garzas merged 6 commits into
developfrom
fix/login-invalid-credentials-error-marking
Jun 9, 2026
Merged

fix: show invalid credentials error on login screens [WPB-14814]#4903
Garzas merged 6 commits into
developfrom
fix/login-invalid-credentials-error-marking

Conversation

@Garzas

@Garzas Garzas commented Jun 1, 2026

Copy link
Copy Markdown
Contributor

https://wearezeta.atlassian.net/browse/WPB-14814


PR Submission Checklist for internal contributors

  • The PR Title

    • conforms to the style of semantic commits messages¹ supported in Wire's Github Workflow²
    • contains a reference JIRA issue number like SQPIT-764
    • answers the question: If merged, this PR will: ... ³
  • The PR Description

    • is free of optional paragraphs and you have filled the relevant parts to the best of your ability

What's new in this PR?

  • Shows a persistent invalid credentials error on the login screen after the dialog is dismissed
  • Applies the same error marking to both old and new email/password login flows
  • Keeps the message generic to avoid revealing whether the email/username or password was incorrect
  • Clears the inline error once the user edits the login input
  • Adds ViewModel coverage for preserving and clearing the error state

@Garzas Garzas requested review from MohamadJaara and saleniuk June 1, 2026 11:06
@Garzas Garzas self-assigned this Jun 1, 2026
@codecov

codecov Bot commented Jun 1, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 49.14%. Comparing base (5d7e15a) to head (3cd2150).

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #4903      +/-   ##
===========================================
+ Coverage    49.12%   49.14%   +0.01%     
===========================================
  Files          650      650              
  Lines        22983    22989       +6     
  Branches      3516     3518       +2     
===========================================
+ Hits         11291    11297       +6     
  Misses       10645    10645              
  Partials      1047     1047              
Files with missing lines Coverage Δ
...d/ui/authentication/login/email/LoginEmailState.kt 100.00% <100.00%> (ø)
.../authentication/login/email/LoginEmailViewModel.kt 79.25% <100.00%> (+0.56%) ⬆️

Continue to review full report in Codecov by Harness.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5d7e15a...3cd2150. Read the comment docs.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Garzas Garzas requested a review from saleniuk June 2, 2026 03:41
@Garzas Garzas requested a review from saleniuk June 2, 2026 18:49
@Garzas Garzas requested a review from sbakhtiarov June 8, 2026 15:37
@sonarqubecloud

sonarqubecloud Bot commented Jun 8, 2026

Copy link
Copy Markdown

@Garzas Garzas added this pull request to the merge queue Jun 9, 2026
Merged via the queue into develop with commit fd2041e Jun 9, 2026
20 checks passed
@Garzas Garzas deleted the fix/login-invalid-credentials-error-marking branch June 9, 2026 08:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants