fix(input-format): validate recovered internal-url keys via parseInternalFileUrl

Addresses review round 5 (Greptile): isInternalFileUrl only checks the URL
prefix, but the executor parses+decodes the key. A malformed internal URL (no
extractable key) passed the prefix check, got collected into workflowInput.files,
then normalizeStartFile rejected it and dropped the whole files array. Now mirror
the executor exactly — attempt parseInternalFileUrl and require a real key.
Tests use a realistic recoverable internal URL.

Author: waleedlatif1

apps/sim/app/workspace/[workspaceId]/w/[workflowId]/components/panel/components/editor/components/sub-block/components/starter/input-format-files.test.ts

@@ -10,7 +10,7 @@ import {
 const file: InputFormatFile = {
   id: 'f1',
   name: 'doc.pdf',
-  url: '/api/files/serve/key',
+  url: '/api/files/serve/workspace%2Fws-1%2F1700000000000-doc.pdf?context=workspace',
   key: 'key',
   size: 10,
   type: 'application/pdf',
@@ -20,11 +20,11 @@ describe('filesToControlValue', () => {
   it.concurrent('maps url -> path for the FileUpload value shape', () => {
     expect(filesToControlValue([file])).toEqual([
       {
-        name: 'doc.pdf',
-        path: '/api/files/serve/key',
-        key: 'key',
-        size: 10,
-        type: 'application/pdf',
+        name: file.name,
+        path: file.url,
+        key: file.key,
+        size: file.size,
+        type: file.type,
       },
     ])
   })
@@ -43,9 +43,7 @@ describe('controlValueToFiles', () => {
   })
 
   it.concurrent('matches an existing file by url when key is absent', () => {
-    const control = [
-      { name: 'doc.pdf', path: '/api/files/serve/key', size: 10, type: 'application/pdf' },
-    ]
+    const control = [{ name: 'doc.pdf', path: file.url, size: 10, type: 'application/pdf' }]
     expect(controlValueToFiles(control, [file])[0].id).toBe('f1')
   })
 
@@ -67,11 +65,11 @@ describe('controlValueToFiles', () => {
 
   it.concurrent('normalizes a single object or null to an array', () => {
     const single = {
-      name: 'doc.pdf',
-      path: '/api/files/serve/key',
-      key: 'key',
-      size: 10,
-      type: 'application/pdf',
+      name: file.name,
+      path: file.url,
+      key: file.key,
+      size: file.size,
+      type: file.type,
     }
     expect(controlValueToFiles(single, [file])).toEqual([file])
     expect(controlValueToFiles(null, [file])).toEqual([])

apps/sim/lib/workflows/input-format.test.ts

@@ -252,7 +252,7 @@ describe('parseInputFormatFiles', () => {
   const file = {
     id: 'f1',
     name: 'doc.pdf',
-    url: '/api/files/serve/key',
+    url: '/api/files/serve/workspace%2Fws-1%2F1700000000000-doc.pdf?context=workspace',
     key: 'key',
     size: 10,
     type: 'application/pdf',
@@ -312,6 +312,13 @@ describe('parseInputFormatFiles', () => {
     expect(parseInputFormatFiles(JSON.stringify([noKey]))).toEqual([noKey])
   })
 
+  it.concurrent('rejects a key-less file whose internal url yields no key', () => {
+    const { key, ...noKey } = file
+    expect(parseInputFormatFiles(JSON.stringify([{ ...noKey, url: '/api/files/serve/' }]))).toEqual(
+      []
+    )
+  })
+
   it.concurrent('rejects empty-string id/name/url/type (executor treats them as falsy)', () => {
     expect(parseInputFormatFiles(JSON.stringify([{ ...file, id: '' }]))).toEqual([])
     expect(parseInputFormatFiles(JSON.stringify([{ ...file, name: '' }]))).toEqual([])
@@ -324,7 +331,7 @@ describe('collectInputFormatFiles', () => {
   const file = {
     id: 'f1',
     name: 'doc.pdf',
-    url: '/api/files/serve/key',
+    url: '/api/files/serve/workspace%2Fws-1%2F1700000000000-doc.pdf?context=workspace',
     key: 'key',
     size: 10,
     type: 'application/pdf',

apps/sim/lib/workflows/input-format.ts

@@ -1,5 +1,5 @@
 import { generateId } from '@sim/utils/id'
-import { isInternalFileUrl } from '@/lib/uploads/utils/file-utils'
+import { isInternalFileUrl, parseInternalFileUrl } from '@/lib/uploads/utils/file-utils'
 import { isInputDefinitionTrigger } from '@/lib/workflows/triggers/input-definition-triggers'
 import type { InputFormatField } from '@/lib/workflows/types'
 import type { UserFile } from '@/executor/types'
@@ -62,6 +62,22 @@ export function isFileFieldType(type: string | null | undefined): boolean {
 export type InputFormatFile = Pick<UserFile, 'id' | 'name' | 'url' | 'size' | 'type'> &
   Pick<Partial<UserFile>, 'key'>
 
+/**
+ * Whether a file's key is usable at run time: an explicit non-empty `key`, or an
+ * internal `/api/files/serve/...` URL the key can actually be parsed from. This
+ * mirrors `normalizeStartFile` exactly (including the parse, so a malformed
+ * internal URL is rejected rather than accepted on the prefix alone).
+ */
+function hasRecoverableFileKey(file: InputFormatFile): boolean {
+  if (typeof file.key === 'string' && file.key.length > 0) return true
+  if (typeof file.url !== 'string' || !isInternalFileUrl(file.url)) return false
+  try {
+    return parseInternalFileUrl(file.url).key.length > 0
+  } catch {
+    return false
+  }
+}
+
 /**
  * Tolerantly parses a file field's stored value (a JSON string, or an already
  * materialized array) into run-ready file objects. Returns an empty array for
@@ -91,9 +107,6 @@ export function parseInputFormatFiles(value: unknown): InputFormatFile[] {
     // as normalizeStartFile). A partial object or external/signed URL without a
     // key is rejected so it never opens in uploader mode or reaches the files
     // channel only to be dropped; it falls back to the JSON editor instead.
-    const hasRecoverableKey =
-      (typeof f.key === 'string' && f.key.length > 0) ||
-      (typeof f.url === 'string' && isInternalFileUrl(f.url))
     // Non-empty strings: normalizeStartFile rejects falsy id/name/url/type, and
     // file normalization is all-or-nothing, so one empty-string field would drop
     // every file from the run.
@@ -108,7 +121,7 @@ export function parseInputFormatFiles(value: unknown): InputFormatFile[] {
       Number.isFinite(f.size) &&
       typeof f.type === 'string' &&
       f.type.length > 0 &&
-      hasRecoverableKey
+      hasRecoverableFileKey(f)
     )
   })
 }