fix(db): use Object.hasOwn for SIM_DB_ROLE validation to avoid prototype keys

TheodoreSpeaks · TheodoreSpeaks · commit 4b05050ed538 · 2026-06-27T12:00:08.000-07:00
diff --git a/packages/db/db.ts b/packages/db/db.ts
@@ -23,7 +23,7 @@ export const DB_POOL_PROFILES = {
 type DbRole = keyof typeof DB_POOL_PROFILES
 
 const roleEnv = process.env.SIM_DB_ROLE?.trim()
-if (roleEnv && !(roleEnv in DB_POOL_PROFILES)) {
+if (roleEnv && !Object.hasOwn(DB_POOL_PROFILES, roleEnv)) {
   throw new Error(
     `Invalid SIM_DB_ROLE '${roleEnv}' — expected one of ${Object.keys(DB_POOL_PROFILES).join(', ')} (or unset for web)`
   )

Original file line number	Diff line number	Diff line change
`@@ -23,7 +23,7 @@ export const DB_POOL_PROFILES = {`
`23`	`23`	`type DbRole = keyof typeof DB_POOL_PROFILES`
`24`	`24`
`25`	`25`	`const roleEnv = process.env.SIM_DB_ROLE?.trim()`
`26`		`-if (roleEnv && !(roleEnv in DB_POOL_PROFILES)) {`
	`26`	`+if (roleEnv && !Object.hasOwn(DB_POOL_PROFILES, roleEnv)) {`
`27`	`27`	`throw new Error(`
`28`	`28`	`Invalid SIM_DB_ROLE '${roleEnv}' — expected one of ${Object.keys(DB_POOL_PROFILES).join(', ')} (or unset for web)`
`29`	`29`	`)`