Skip to content

Commit 3cc1fcd

Browse files
Revert "fix(emcn): promote modal overlay + content wrapper to own compositing layers"
This reverts commit 52145ed.
1 parent 52145ed commit 3cc1fcd

1 file changed

Lines changed: 2 additions & 10 deletions

File tree

packages/emcn/src/components/modal/modal.tsx

Lines changed: 2 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -122,14 +122,6 @@ const ModalClose = DialogPrimitive.Close
122122
* Modal overlay component with fade transition.
123123
* Outside interactions are handled by the dialog content so nested poppers can
124124
* close without also dismissing the modal.
125-
*
126-
* `[transform:translateZ(0)]` forces the overlay onto its own compositing layer.
127-
* A `backdrop-blur` overlay does not reliably paint above page content the
128-
* browser has already GPU-promoted — `position: sticky` headers and `z-index`ed
129-
* absolutes inside a scroll container (e.g. the scheduled-tasks calendar) can
130-
* sort ABOVE it despite its higher `z-index`, bleeding through. Promoting the
131-
* overlay (and the content wrapper below, so the panel occludes too) makes the
132-
* compositor honor stacking order.
133125
*/
134126
const ModalOverlay = React.forwardRef<
135127
React.ElementRef<typeof DialogPrimitive.Overlay>,
@@ -139,7 +131,7 @@ const ModalOverlay = React.forwardRef<
139131
<DialogPrimitive.Overlay
140132
ref={ref}
141133
className={cn(
142-
'fixed inset-0 z-[var(--z-modal)] bg-black/10 backdrop-blur-[2px] [transform:translateZ(0)]',
134+
'fixed inset-0 z-[var(--z-modal)] bg-black/10 backdrop-blur-[2px]',
143135
ANIMATION_CLASSES,
144136
className
145137
)}
@@ -237,7 +229,7 @@ const ModalContent = React.forwardRef<
237229
<ModalPortal>
238230
<ModalOverlay />
239231
<div
240-
className='pointer-events-none fixed inset-0 z-[var(--z-modal)] flex items-center justify-center [transform:translateZ(0)]'
232+
className='pointer-events-none fixed inset-0 z-[var(--z-modal)] flex items-center justify-center'
241233
style={
242234
size === 'full'
243235
? undefined

0 commit comments

Comments
 (0)